Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly named "date" property in filteredData? #227

Closed
gassc opened this issue Mar 6, 2018 · 2 comments
Closed

explicitly named "date" property in filteredData? #227

gassc opened this issue Mar 6, 2018 · 2 comments
Labels

Comments

@gassc
Copy link
Contributor

gassc commented Mar 6, 2018

I'm really liking this tool and the way it abstracts away some of the boilerplate required to get a D3 visualization like this up and running. So, thank you.


I think I'm noticing an issue that may be related to this line where filteredData is established (but I'm not entirely sure):

withinRange(d.date, dateBounds)

Does this mean that the event data objects must always have a date property, with that name exactly?

What I'm seeing:

If my event objects don't explicitly have a date property (in my case my data has a datetime property instead), the resulting filteredData object's data property is empty while the fullData property is complete (so nothing appears on the timeline).

image

If I run a data transformation ahead of time, renaming my datetime property to date, then things work as expected.

Running a transformation ahead of time is not an issue at all (and in fact I need to do that anyway, just like in the demo), but I just wanted to confirm what I'm seeing.

@jpetitcolas
Copy link
Contributor

Good catch! We indeed should use the config.drop.date function here. It definitively worths a PR! :)

@jpetitcolas
Copy link
Contributor

Released in 1.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants