Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presenting CountryCodePickerViewController causes 50% frozen frame rates #833

Open
hyouuu opened this issue Feb 21, 2025 · 0 comments
Open

Comments

@hyouuu
Copy link

hyouuu commented Feb 21, 2025

New Issue Checklist

  • [v] Updated PhoneNumberKit to the latest version
  • [v] Phone number formatted correctly on JavaScript version
  • [v] I searched for existing GitHub issues
  • [v] I am aware that this library is not responsible of adding/removing/changing phone number formats and any request should be done at libphonenumber repo

Steps to reproduce

Presenting CountryCodePickerViewController

Expected result

UI loads smoothly without freeze

Actual result

Firebase performance catches that the CountryCodePickerViewController causes frozen frames almost all the time.
Looked at the code and it's probably initializing the country code on the main thread - should have a loading state and load countries in background, and ideally lazily

Environment

SPM 4.0.1 on iOS in various versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant