Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG/ISSUE] Winget version parsing is being trimmed if it's more than one string #823

Closed
5 tasks done
Mikey1993 opened this issue Mar 19, 2023 · 7 comments
Closed
5 tasks done
Assignees
Labels
bug Something isn't working

Comments

@Mikey1993
Copy link
Contributor

Mikey1993 commented Mar 19, 2023

Before submitting the issue

  • I have checked that the bug is not a duplicate or, if it is, it needs to be reopened
  • I have checked that I am running the latest version of WingetUI
  • I have tried resetting and reinstalling WingetUI and the issue persisted or happened again
  • I have checked the FAQ section for solutions
  • I have read the contributing guidelines and I agree with the Code of Conduct

Describe the bug

There seem to be a bug with parsing the version of a package which it's version is consisting of two string separated by a space

To Reproduce

Steps to reproduce the behaviour:

  1. Go to the "Discover Packages"
  2. Click on the Version text in the first row to sort it so it will show like that:
    image
  3. This is a trimmed text of the full version string
  4. Verify that by showing info of this package, you can clearly see that it is being trimmed:
    image

Info about the package from winget:
image

Expected behaviour

Package version shows "WIA-Loader 2.7.30" in the table (not trimmed)

Please note that I don't think that this is the same bug as in #805

@Mikey1993 Mikey1993 added the bug Something isn't working label Mar 19, 2023
@marticliment
Copy link
Owner

This is an issue actually caused by Winget.exe, that is that when using winget search *, longer texts are trimmed instead of shwon completely.

This issue can't be fixed, but it might get resolved with the implementation of #712 (we would get rid of console parsing)

@Mikey1993
Copy link
Contributor Author

This is an issue actually caused by Winget.exe, that is that when using winget search *, longer texts are trimmed instead of shwon completely.

This issue can't be fixed, but it might get resolved with the implementation of #712 (we would get rid of console parsing)

How so is that a problem with winget.exe output?
This is what I get:
image

Per https://learn.microsoft.com/en-us/windows/package-manager/winget/search it says:
image

@marticliment
Copy link
Owner

marticliment commented Mar 20, 2023

It behaves like this:
image

See #196 for further details

Sorry, it was #193: #193 (comment)

@marticliment marticliment closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2023
@Mikey1993
Copy link
Contributor Author

Mikey1993 commented Mar 20, 2023

@marticliment ,
But it doesn't seem to affect this package as I see the version and the app name fully, so how is it related to this bug?

Also, seems like with the new winget-cli v1.5, there will be better handling of version through the winget search command:
microsoft/winget-cli#2847

@marticliment
Copy link
Owner

When showing few packages, winget adapts its width to the full length. When showing all packages, it does not.

This is an open issue in winget's repository

@ppvnf
Copy link
Contributor

ppvnf commented Mar 20, 2023

hopefully v1.5 will fix it

microsoft/winget-cli#2603

@Mikey1993
Copy link
Contributor Author

Mikey1993 commented Mar 20, 2023

When showing few packages, winget adapts its width to the full length. When showing all packages, it does not.

This is an open issue in winget's repository

Can't believe that even a simple output format (like JSON for example) is not available for proper parsing these days.
Thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants