Crash when Git's core.excludesFile points to non-existent file
#131
Comments
martinvonz
added a commit
that referenced
this issue
Mar 13, 2022
…issing I thought that `std::fs::canonicalize()` expanded "~", but it doesn't seem to do that, which caused #131. Git seems to do the expansion itself, so we probably also should. More importantly `std::fs::canonicalize()` crashes when the file doesn't exist. The manual expansion we do now does not. Closes #131.
martinvonz
added a commit
that referenced
this issue
Mar 13, 2022
I thought that `std::fs::canonicalize()` expanded "~", but it doesn't seem to do that, which caused #131. Git seems to do the expansion itself, so we probably also should. More importantly `std::fs::canonicalize()` crashes when the file doesn't exist. The manual expansion we do now does not. Closes #131.
martinvonz
added a commit
that referenced
this issue
Mar 13, 2022
I thought that `std::fs::canonicalize()` expanded "~", but it doesn't seem to do that, which caused #131. Git seems to do the expansion itself, so we probably also should. More importantly `std::fs::canonicalize()` crashes when the file doesn't exist. The manual expansion we do now does not. Closes #131.
martinvonz
added a commit
that referenced
this issue
Mar 13, 2022
I thought that `std::fs::canonicalize()` expanded "~", but it doesn't seem to do that, which caused #131. Git seems to do the expansion itself, so we probably also should. More importantly `std::fs::canonicalize()` crashes when the file doesn't exist. The manual expansion we do now does not. Closes #131.
martinvonz
added a commit
that referenced
this issue
Mar 13, 2022
I thought that `std::fs::canonicalize()` expanded "~", but it doesn't seem to do that, which caused #131. Git seems to do the expansion itself, so we probably also should. More importantly `std::fs::canonicalize()` crashes when the file doesn't exist. The manual expansion we do now does not. Closes #131.
martinvonz
added a commit
that referenced
this issue
Mar 13, 2022
I thought that `std::fs::canonicalize()` expanded "~", but it doesn't seem to do that, which caused #131. Git seems to do the expansion itself, so we probably also should. More importantly `std::fs::canonicalize()` crashes when the file doesn't exist. The manual expansion we do now does not. Closes #131.
martinvonz
added a commit
that referenced
this issue
Mar 14, 2022
This release is just to get #131 out and to see if the automated release builds work now that we use a vendored OpenSSL from libgit2.
martinvonz
added a commit
that referenced
this issue
Mar 14, 2022
This release is just to get #131 out and to see if the automated release builds work now that we use a vendored OpenSSL from libgit2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
I had configured
core.excludesFilein my~/.gitconfigto point to~/.gitignore, but I didn't have such a file. That madejj stin a Git-backed repo crash.Specifications
The text was updated successfully, but these errors were encountered: