Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseResource._keys() method does not return dict attributes. #52

Open
cans opened this issue Nov 1, 2017 · 1 comment
Open

BaseResource._keys() method does not return dict attributes. #52

cans opened this issue Nov 1, 2017 · 1 comment

Comments

@cans
Copy link
Contributor

cans commented Nov 1, 2017

The method BaseResource._key() does not include the attributes decalred in BaseResource._dicts.

Is that intentional or not ? Chaiging this would impact the following methods:

That latter method seem to be dead code: never called anywhere as far as grep can tell, but then it is also part of the class public AP, so removing it may not be the best idea. But if we agree the omission of dict attributes is a bug, then it should be fixed.

Any clue ?
Regards, Nicolas.

@cans
Copy link
Contributor Author

cans commented Nov 1, 2017

By the way should that ._keys() method be a @classmethod makes to make introspection at the class level as much as at the instance level no ? Changing that would not break the API).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant