Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] Messenger reports "upgrade" to lower version; always appears outdated #331

Closed
sjml opened this issue Mar 20, 2021 · 12 comments
Closed
Labels

Comments

@sjml
Copy link

sjml commented Mar 20, 2021

Your Environment

  • mas version: 1.8.1
  • macOS version (system_profiler SPSoftwareDataType -detailLevel mini): 10.15.7

mas Install Method

  • ☑️ brew install mas (homebrew-core)
  • [] mas-cli/tap
  • [] .pkg installer from releases
  • [] Built from source
    • Fork/branch: ? (e.g. mas-cli/master)
    • Xcode version: 10.?

Describe the Bug

When running mas upgrade to upgrade Messenger (1480068668), it still shows up in the outdated list. It seems to be a problem that it's reporting an "upgrade" needed to a lower version number?

To Reproduce

Steps to reproduce the behavior:

  1. Run mas outdated to see Messenger in need of upgrade.
  2. Run mas upgrade to update it.
  3. Note that it still appears when mas outdated is run again.

(Terminal log below)

Expected Behavior

A recently upgraded program will no longer be listed as outdated.

Actual Behavior

Messenger seems to always be in need of an upgrade.

Screenshots, Terminal Output

% mas outdated
1480068668 Messenger (95.7.118 -> 92.0)
% mas upgrade
Upgrading 1 outdated application:
Messenger (95.7.118)
==> Downloading Messenger
==> Installed Messenger
% mas outdated
1480068668 Messenger (95.7.118 -> 92.0)

The installed version of Messenger does report itself as 95.7.118.

@sjml sjml added the 🐛 bug label Mar 20, 2021
@chris-araman
Copy link
Contributor

The bundle version does not match the App Store version.

<key>CFBundleShortVersionString</key><string>95.7.118</string>

This seems to be a regression from #312.

@GentleHoneyLover
Copy link

Exactly the same issue here.

macOS version 11.2.3 (20D21)
mas version 1.8.1

% mas outdated 1477857867 DevSwatch (1.3 -> 1.1) 1510445899 Meeter (1.9.3 -> 1.1.3)

Both of these apps are already at their latest versions. But mas keeps upgrading them.

@duhd1993
Copy link

There have been several related issues. #290
Your problem seems a little different. mas info and mas outdated reported v92.0. appstore also shows v92.0 But the version installed is 95.7.118. #312 didn't do anything wrong here. It's appstore.

@sjml
Copy link
Author

sjml commented Mar 22, 2021

I wonder if mas should be reporting "outdated" if the installed version is higher than the reported version from the App Store. Understanding that there's not much that can be done on the tool side to make sure the App Store metadata matches the app's plist, maybe it could at least assume that version numbers increase over time rather than decrease.

@alexbarton
Copy link

I’m seeing this as well – but only mas shows those apps as outdated and tries to „upgrade“ it over and over again; not the App Store application itself. So the App Store app uses an different logic to detect „outdated“ apps?

❯ mas outdated
1225393668 Code Reader (5.12.3 -> 5.12.2)
1481669779 Evernote Web Clipper (1.0.11 -> 7.13.6)
1480068668 Messenger (95.7.118 -> 92.0)

@RickyRomero
Copy link

r@burnout ~ % mas outdated
1015043880 Shut Up (3.1 -> 1.10)

I have a universal app on the App Store which has different versions available on iOS and macOS. Both versions share a bundle ID - com.rickyromero.shutup but are currently based on different source trees. The latest macOS version is 3.1, and the latest iOS version is 1.10.

Perhaps this explains the strange behavior?

@chris-araman
Copy link
Contributor

chris-araman commented Apr 27, 2021

The issue with Messenger for macOS should be resolved by #346. The absence of iOS apps is tracked in #321.

I have a universal app on the App Store which has different versions available on iOS and macOS. Both versions share a bundle ID - com.rickyromero.shutup but are currently based on different source trees. The latest macOS version is 3.1, and the latest iOS version is 1.10.

@RickyRomero, would you be willing to open a new issue with details on this?

Let's use #336 (comment) to track the confusion between macOS and iOS/iPadOS apps.

@jaklan
Copy link

jaklan commented May 6, 2021

@chris-araman when can we expect the release incl. that fix? Or maybe any pre-release?

@chris-araman
Copy link
Contributor

chris-araman commented May 6, 2021

@jaklan, I'm not sure what @phatblat has in mind. AFAIK, the migration from Bintray to GitHub Packages might be the only thing blocking release, but I think that only blocks release to the Homebrew tap for macOS 10.11 through 10.14.

@phatblat, would it be possible to get a release out sooner, without waiting for that migration? If you'd like me to try running through the Release steps on the wiki, please let me know. :)

@phatblat
Copy link
Member

phatblat commented May 7, 2021

The homebrew formula update is the first tricky part. The last couple releases I've tagged and somebody started updating the formula before I could get to it. That's fine when only a version bump is needed, but we changed the formula a bit with the removal of carthage.

I'll start rolling out 1.8.2 now.

@phatblat
Copy link
Member

phatblat commented May 7, 2021

The 1.8.2 release is up and has a .pkg installer attached. Homebrew is going to take a little longer as I hit a snag updating the formula #363

@chris-araman
Copy link
Contributor

Thanks, @phatblat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants