Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lucky after providing replacements #608

Open
rgoldberg opened this issue Oct 27, 2024 · 0 comments
Open

Remove lucky after providing replacements #608

rgoldberg opened this issue Oct 27, 2024 · 0 comments

Comments

@rgoldberg
Copy link
Contributor

rgoldberg commented Oct 27, 2024

Remove lucky after providing better replacements.

It is non-deterministic. It complicates the UX. It should not be used.

The best ways to replace it are to:

  • provide tab-completion that searches the iTunes Search API for the typed text, but that replaces the typed text with an app ID.
  • accept deterministic bundle IDs everywhere app IDs are accepted as arguments. Also, it is more obvious that the bundle ID com.apple.iWork.Pages references Apple's Pages app than that the app ID 409201541 references that same Pages app.

If both the above are implemented. tab completion would try to complete installed app IDs when a number is typed where an app ID for an installed app would be appropriate (like for mas upgrade, but not for mas purchase), and to complete bundle IDs & to search the App Store like mas search (for commands like mas purchase) or search installed app names (for commands like mas uninstall).

Another possible associated change: tab completion could complete to bundle IDs instead of to app IDs.

In fact, bundle IDs should probably be preferred over app IDs, and we should output bundle IDs everywhere we output app IDs to facilitate everyone using bundle IDs instead of app IDs.

@rgoldberg rgoldberg added the 🧹 cleanup Optimization of (not bug fix for) an existing feature label Oct 27, 2024
@rgoldberg rgoldberg changed the title Remove lucky Remove lucky after providing better replacements Oct 27, 2024
@rgoldberg rgoldberg added 🆕 feature request and removed 🧹 cleanup Optimization of (not bug fix for) an existing feature labels Oct 28, 2024
@rgoldberg rgoldberg changed the title Remove lucky after providing better replacements Remove lucky after providing replacements Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant