Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot read property 'string' of undefined #240

Open
RaviDhiman0009 opened this issue Oct 24, 2017 · 3 comments
Open

Cannot read property 'string' of undefined #240

RaviDhiman0009 opened this issue Oct 24, 2017 · 3 comments

Comments

@RaviDhiman0009
Copy link

RaviDhiman0009 commented Oct 24, 2017 •
edited
Loading

when i'm import the module ( import { Button } from 'react-lightning-design-system'; ) i got the error on my browser window "Cannot read property 'string' of undefined". even i am not using it.

( But I found that it is working with react v15.6.1 )

lightingdesign
@bondz
Copy link
Contributor

bondz commented Oct 25, 2017 •
edited
Loading

Yes, because PropTypes were deprecated in React 15.5 and removed in React 16. #238 should fix that problem.

@itsrifat
Copy link

itsrifat commented Nov 22, 2017 •
edited
Loading

Still happening in v2.4.5. There are still references to React.PropTypes here:

react-lightning-design-system/src/scripts/Table.js

Line 167 in 6e1f587

React.PropTypes.string,

and here:

react-lightning-design-system/stories/GridStories.js

Line 16 in 1e80f87

children: React.PropTypes.node,

@bondz
Copy link
Contributor

bondz commented Nov 22, 2017

Not sure if master has been pushed to NPM yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@itsrifat @bondz @RaviDhiman0009