How are bad input parameters handled?

[marv-engine]

What does MasterCore do & return when an invalid value is passed as an input parameter, e.g. to one of the query api's? Is that detected as an error or does it just return nothing?

Is there a list of error codes and their meaning?

[zathras-crypto]

Each RPC call is an independent entity. The input parameters are checked, and RPC errors returned on bad values. Error codes are not unique at this stage, but the human readable errors describe the error. It is on the 'todo' list to go through every human readable error and assign unique error codes etc to these but not prioritized highly, as we're often moved onto new things as soon as something 'works' rather than 'finished'.

Thanks
Z

[zathras-crypto]

Example

    int64_t tmpPropertyId = params[0].get_int64();
    if ((1 > tmpPropertyId) || (4294967295 < tmpPropertyId)) // not safe to do conversion
            throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid property ID");

    unsigned int propertyId = int(tmpPropertyId);
    CMPSPInfo::Entry sp;
    if (false == _my_sps->getSP(propertyId, sp)) {
      throw JSONRPCError(RPC_INVALID_PARAMETER, "Property ID does not exist");
    }

[marv-engine]

Got it. Thx.

[dexX7]

Slightly related: I think getXbalance should not throw exceptions, but rather respond with 0.0 or an empty array, if "address does not exist (for property N)", unless input format is wrong.