Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually script injections order. #64

Open
sultan99 opened this issue May 10, 2019 · 2 comments
Open

Manually script injections order. #64

sultan99 opened this issue May 10, 2019 · 2 comments

Comments

@sultan99
Copy link

Is there a way to tell the plugin the order of script injections in index.html?

react-redux has peer/optional dependency - react-dom but it is not declared in package.json. Sometime (randomly) the react-redux is being injected before the react-dom by dynamic-cdn-webpack-plugin and cause exceptions.

I have asked to add react-dom in optional dependency and even sent PR but it was refused.

@mastilver
Copy link
Owner

Hi @sultan99

Thank you for reporting this issue

Two solution here:

  • your solution: add an options to order urls (open to API suggestion)
  • add a field on module-to-cdn that override the peer-dependencies

@sultan99
Copy link
Author

sultan99 commented Jun 6, 2019

@mastilver you mean to add this feature? Will you accept my PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants