chore(demos): Use CSS files directly instead of Webpack's .css.js #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `MDC_WRAP_CSS_IN_JS` env var now defaults to `false`
Codecov Report
@@ Coverage Diff @@
## master #1916 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 84 84
Lines 3721 3721
Branches 484 484
=======================================
Hits 3700 3700
Misses 21 21Continue to review full report at Codecov.
|
acdvorak
added a commit
that referenced
this pull request
Jan 19, 2018
This PR also adds hot reloading of stylesheets that have a `data-hot` attribute. Currently, only the theme demo page has a `<link rel="stylesheet" href="..." data-hot>` element, but I plan to create follow-up PRs to add hot swapping to the remaining demo pages. Hot swapping was broken when we switched to CSS files in #1916. When Webpack starts recompiling our Sass, the theme demo page displays a linear-progress bar in the toolbar until compilation finishes, at which point it automatically swaps in the new stylesheet. I tested this PR in: - Chrome 63 (desktop and mobile) - Firefox 57 (desktop) - Safari 11 (desktop and mobile) - IE 11 - Edge 14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Sass source maps and hot reloading no longer work on demo pages. We can address those issues in future PRs if they become a problem. In addition, the
MDC_WRAP_CSS_IN_JSenv var now defaults tofalse.This change:
getComputedStyle()on page load (e.g., ripple)