fix(tabs): centered and adjusted vertical placement of css-only tab indicator #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moog16
commented
Jan 30, 2018
packages/mdc-tabs/tab/mdc-tab.scss
Outdated
| @@ -95,10 +95,11 @@ $mdc-tab-with-icon-and-text-height: 72px; | |||
| } | |||
|
|
|||
| .mdc-tab__indicator { | |||
| $mdc-tab-indicator-horizontal-padding: 2px; | |||
There was a problem hiding this comment.
Not sure if this is confusing. I could just inline these values.
There was a problem hiding this comment.
Do we really need this as a variable? If so, I think it should go next to the others on line 26.
There was a problem hiding this comment.
Na we don't...I thought it might be clearer, but its not complicated math. I'll remove it
Codecov Report
@@ Coverage Diff @@
## master #2141 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 84 84
Lines 3768 3768
Branches 489 489
=======================================
Hits 3740 3740
Misses 28 28Continue to review full report at Codecov.
|
williamernest
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2117