Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-field): move script tags below mdc.js tag #2179

Merged
merged 4 commits into from
Feb 5, 2018

Conversation

moog16
Copy link
Contributor

@moog16 moog16 commented Feb 3, 2018

This PR is to allow text-field demo page to render properly. This is only a temporary fix as the real fix is to update demoReady with a listener for DOMContentLoaded.

#2180 Fixed the demo pages. Purpose of this is to just condense all the <script> together into one.

@codecov-io
Copy link

codecov-io commented Feb 3, 2018

Codecov Report

Merging #2179 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2179   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files          90       90           
  Lines        3843     3843           
  Branches      497      497           
=======================================
  Hits         3810     3810           
  Misses         33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a633cf5...d300dc7. Read the comment docs.

@kfranqueiro
Copy link
Contributor

#2180 fixes demoReady FYI

@moog16 moog16 closed this Feb 3, 2018
@moog16 moog16 deleted the fix/text-field/mdc-not-defined branch February 3, 2018 01:21
@moog16 moog16 restored the fix/text-field/mdc-not-defined branch February 3, 2018 01:28
@moog16 moog16 reopened this Feb 3, 2018
@moog16 moog16 merged commit f5e506f into master Feb 5, 2018
@moog16 moog16 deleted the fix/text-field/mdc-not-defined branch February 5, 2018 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants