-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chips): Handle multi-select for filter chips #2297
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2297 +/- ##
==========================================
+ Coverage 99.04% 99.07% +0.02%
==========================================
Files 99 99
Lines 3999 4004 +5
Branches 513 515 +2
==========================================
+ Hits 3961 3967 +6
+ Misses 38 37 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but...are filter chips supposed to be removable eventually? We might have to handle that carefully to make sure stale chips don't end up in the activeChips array...
Yep, we also have to make sure that stale chips are removed from the chip-set's @kfranqueiro I'm maybe rethinking the design of this... what do you think about adding a |
We discussed offline and decided to stick with the selectedChips array, figuring that the number of total chips is more likely to far outnumber the number of selected chips to the point where this may be ultimately more efficient. Moreover, having the separate array may be helpful for eventually providing information on selected chips in events. |
Add multiple selection behavior for filter chips.
Follow-up PRs will address #2295 and #2296.