New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the npm package for the BZVisualizer.js #12

Open

dou-du wants to merge 4 commits into materialscloud-org:develop from dou-du:develop

dou-du commented May 10, 2021

We are going to use the npm package "brillouinzone-visualizer" for the BZVisualizer.js file.

dou-du and others added 4 commits

May 1, 2021 03:04


          correct the user_static directory

5df0a9f


          Merge branch 'develop' of github.com:materialscloud-org/tools-seekpat…

f8fe504

…h into develop


          use the npm package

b6d00d2


          Update build-docker.sh

4fcb601

Change it back

dou-du requested a review from giovannipizzi

May 10, 2021 19:04

Contributor

giovannipizzi commented May 11, 2021

Can you also please remove all existing references in the repo to the BZ visualiser, so we are sure we're using the one from NPM and not static versions found here?
Can you pin the version of the npm package to a specific version that you tested?
Did you try to create the container and check that all works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet