Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I believe punycode.decode("ls8h=") should be an error #129

Closed
domenic opened this issue Mar 4, 2023 · 2 comments
Closed

I believe punycode.decode("ls8h=") should be an error #129

domenic opened this issue Mar 4, 2023 · 2 comments

Comments

@domenic
Copy link

domenic commented Mar 4, 2023

I don't know the actual punycode algorithm, but based on the URL Standard test cases expecting https://xn--ls8h=/ to be an error, and jsdom/whatwg-url not passing this, I think the issue is with Punycode. punycode.decode("ls8h=") gives me "💧💩" instead of erroring.

/cc @karwa who seems to have enough of the Punycode algorithm in their head to be able to contribute fixes, potentially 🙏

@karwa
Copy link
Contributor

karwa commented Mar 6, 2023

I think I fixed this already 😊 - #124

When I try it on the RunKit NodeJS playground, the example does throw an error: https://runkit.com/embed/2b1uqmww0euj

@domenic
Copy link
Author

domenic commented Mar 6, 2023

Hmm, I was pretty sure I had updated my dependencies, but I guess not!

@domenic domenic closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants