Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent commit messages reference the wrong PRs #1829

Closed
progval opened this issue Nov 14, 2024 · 2 comments
Closed

Recent commit messages reference the wrong PRs #1829

progval opened this issue Nov 14, 2024 · 2 comments

Comments

@progval
Copy link
Contributor

progval commented Nov 14, 2024

It looks like these recent commit messages: 3.0.2...3.0.3

were made as PRs in a new private repository, squash-merged, and pushed to this one. This makes Github create commit messages referencing PR numbers in your private repository, but also link to unrelated issues and PRs in this repository.
@tadzik
Copy link
Contributor

tadzik commented Nov 14, 2024

Yeah, that's exactly what happened.

Unfortunate, but I don't think it's worth fixing now (given that it'd require rewriting git history). I'll remove them from the changelog though.

tadzik added a commit that referenced this issue Nov 14, 2024
@tadzik
Update the Changelog to match the release notes
062f3ac 
It no longer references PRs from a private repo,
which addresess #1829.
@tadzik
Copy link
Contributor

tadzik commented Nov 14, 2024

Please do reopen if you can think of a better way to address this. Thanks for the callout!

@tadzik tadzik closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tadzik @progval