-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec a mechanism for retracting 3PID invites (SPEC-322) #146
Comments
Jira watchers: @illicitonion @ara4n |
Could you describe the flow you expect users to take? |
In a matrix client I expect to be able to click on a 3PID invite and hit a cancel button. We could conceivably notify the 3PID target that the invite has been retracted, but in practice it's probably not worth it and we can just give them a "sorry, this invite is no longer valid" when they try to accept it. -- @ara4n |
Who should be allowed to do this? Right now, this doesn't exist for regular invites. The original inviter? Anyone with "kick" power level? A new power level? After some discussion with Erik and Mjark, there's no way to establish a happens-before relationship between the invite being cancelled and an attempted join event, so we're not going to be able to be resilient to people forking the graph and joining despite the cancellation. We can do this check in a federation-join by having the danced-with server check its current state, but that may be wrong. Either way, I think this requires enough thought that Erik will probably end up being the one to do it :) |
It does already exist for regular invites. If you kick the invitee from the room, they are no longer invited. Anyone with "kick" power level should be able to retract invites. But bleurgh and fair enough regarding the causality mess. Sounds like Erik gets this prize then - although I'd hope we can directly take inspiration from non-3PID invites... -- @ara4n |
I manage a few rooms and the list of invalid invites is getting longer and longer. What about simply expiring 3PID invites after a week or so? |
Element Web implements this by setting the content of the |
sgtm |
That still doesn't retract the invite, it just makes it useless. Would be nice to clean it up properly. |
What happened here? Is there any open questions left? |
gah, I missed @turt2live's comment. As he says: we need a way to properly retract invites, rather than just making them unusable. |
This is not the same as retracting an invite. The invitee could also have had invites from other users (into the same room). Kicking the invitee would invalidate all of these invites, not just one. Right? |
@ExtinctPatronageDeodorize A Matrix user can only have one invite at a time. |
Submitted by @matthew:matrix.org
(Imported from https://matrix.org/jira/browse/SPEC-322)
The text was updated successfully, but these errors were encountered: