From 655e627f65c3d58989b8f3b70bbee78a6f7c0fa5 Mon Sep 17 00:00:00 2001 From: David Robertson Date: Mon, 18 Sep 2023 14:39:48 +0100 Subject: [PATCH 1/2] Get CI to check the PR has been signed-off Uses Half-Shot's action from https://github.com/matrix-org/backend-meta/blob/release/v2/.github/workflows/sign-off.yml. I've set this up in the sliding sync repo and it seems to have worked well. --- .github/workflows/tests.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index fb117380d028..b5fffb365375 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -12,6 +12,10 @@ concurrency: cancel-in-progress: true jobs: + check-signoff: + if: "github.event_name == 'pull_request'" + uses: "matrix-org/backend-meta/.github/workflows/sign-off.yml@v2" + # Job to detect what has changed so we don't run e.g. Rust checks on PRs that # don't modify Rust code. changes: @@ -225,6 +229,7 @@ jobs: - check-lockfile - lint-clippy - lint-rustfmt + - check-signoff runs-on: ubuntu-latest steps: - run: "true" @@ -627,9 +632,10 @@ jobs: with: needs: ${{ toJSON(needs) }} - # The newsfile lint may be skipped on non PR builds + # The newsfile and signoff lints may be skipped on non PR builds # Cargo test is skipped if there is no changes on Rust code skippable: | + check-signoff lint-newsfile cargo-test cargo-bench From 5616ce7d190bace142495d91abb992e3e07575c5 Mon Sep 17 00:00:00 2001 From: David Robertson Date: Mon, 18 Sep 2023 14:45:24 +0100 Subject: [PATCH 2/2] Changelog --- changelog.d/16348.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/16348.misc diff --git a/changelog.d/16348.misc b/changelog.d/16348.misc new file mode 100644 index 000000000000..846bb048c83b --- /dev/null +++ b/changelog.d/16348.misc @@ -0,0 +1 @@ +Get CI to check PRs have been signed-off.