Bug: Light group lists all supported_color_modes

[matt8707]

Looks like the group header is picking up multiple "Color" options from the members:

Originally posted by @Plawasan in #177 (comment)

[matt8707]

I'm not sure how to solve this. It does, however, correctly list the available color modes.

supported_color_modes: color_temp, hs, rgbw, rgbww, white, xy

[Plawasan]

I would expect the group view to show the lowest common denominator of the group, i.e. only the features, that every member of the group supports... in my case it would only be a on/off toggle, if every member supported brightness then show also that bar etc etc..

[matt8707]

Right, that makes sense. You can't change the color for every light in a group if half of the group doesn't even support color. I just checked what HA does, they do the opposite, they use the greatest common denominator.

demo rgbww light, group gets full color functionality of rgbww, hue temperature light in the mix, hue color lights

supported_color_modes: color_temp, hs, rgbw, rgbww, white, xy

[anarion80]

The same happens for individual lights as well:

(with the particular light reporting: supported_color_modes: color_temp, hs, rgb)

And then we loop all color modes:

{#each supportedColorModes as mode}

which creates duplicate buttons.

If feels like we should somehow map all the possible values for color_modes into one color boolean and only show one (assuming the handling is the same).

[Plawasan]

Interesting.. (obviously) same for me however it doesn't really make a lot of sense to me when you e.g. increase the brightness of the group from say 50% to 60%, all the on/off lights just come on at 100% (nothing else they can do). I understand wanting to make the behavior consistent with HA but that doesn't mean the HA implementation makes a ton of sense :)

[matt8707]

If feels like we should somehow map all the possible values for color_modes into one color boolean and only show

Yeah, will fix that

I understand wanting to make the behavior consistent with HA but that doesn't mean the HA implementation makes a ton of sense

I'm just trying to understand why they chose that approach. It's more complicated to check all the children of a group to see what they support and then compare them to each other, rather than simply checking the group's "supported_color_modes." Perhaps that's the reason; it's just simpler.