Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-856]: Added the requested reviewers in the pulls_created notification #859

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Dec 3, 2024

Summary

Added the requested reviewers in the pulls_created notification

Ticket Link

Fixes #856

Screenshots

Existing

Screenshot from 2024-12-03 16-32-17

Updated

Screenshot from 2024-12-03 18-17-18

Testing step

  • Create a subscription to a project
  • Create a PR and add a reviewer to it
  • Check the notifcation

@Kshitij-Katiyar Kshitij-Katiyar added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Dec 3, 2024
@Kshitij-Katiyar Kshitij-Katiyar self-assigned this Dec 3, 2024
@raghavaggarwal2308 raghavaggarwal2308 added this to the v2.4.0 milestone Dec 3, 2024
server/plugin/template.go Outdated Show resolved Hide resolved
Co-authored-by: Raghav Aggarwal <[email protected]>
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@raghavaggarwal2308 raghavaggarwal2308 removed the 2: Dev Review Requires review by a core committer label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add display of the "Reviewers" field to the pull request creation event template
3 participants