Configure time position #519
Conversation
Add css style 'time-on-sode' to your calendar component to use
Codecov Report@@ Coverage Diff @@
## master #519 +/- ##
==========================================
+ Coverage 95.82% 95.83% +0.01%
==========================================
Files 26 26
Lines 695 697 +2
==========================================
+ Hits 666 668 +2
Misses 29 29
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
This looks fantastic, thank you! Will check it out locally tomorrow when I'm at a computer.
The only things I can spot off the top of my head are, can you remove the dist files from the commit as these get auto generated on release. Could you also undo the eslint configuration changes and fix any errors they highlight.
|
Ah yep, I wondered about the dist stuff. |
This is done by the build when angular-bootstrap-calendar is released
src/directives/mwlCalendarDay.js
Outdated
| @@ -105,7 +109,8 @@ angular | |||
| dayViewEventWidth: '=', | |||
| customTemplateUrls: '=?', | |||
| cellModifier: '=', | |||
| templateScope: '=' | |||
| templateScope: '=', | |||
| timePosition: '=' | |||
There was a problem hiding this comment.
Travis is failing because of a trailing space at the end of this line, can you fix it please?
|
The dist files are still changed, I think if you sync your fork with this repos master and then just copy the dist files across it should fix it. |
|
How's that @mattlewis92? |
|
The dist files are still included, can you fix them? (Maybe just download them from master and overwrite manually)
… On 18 Jan 2017, at 10:53, Dylan Watson ***@***.***> wrote:
How's that @mattlewis92?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
src/directives/mwlCalendarDay.js
Outdated
| @@ -8,6 +8,10 @@ angular | |||
|
|
|||
| var vm = this; | |||
|
|
|||
| vm.timePosition = vm.timePosition ? vm.timePosition : 'default'; | |||
| vm.timeHidden = vm.timePosition === 'hidden'; | |||
| vm.timePositionOffset = vm.timePosition !== 'default' ? 0 : 60; | |||
There was a problem hiding this comment.
In order for this to work it needs to be inside the refreshView() function, as with ng 1.6+ these inputs wont be initialised on the components construction.
|
Tried to fix the dist files myself through githubs UI but it keeps adding new lines to the end of the files |
|
Thought I'd reverted the dist... I'll have to take another look. I'll take a look at that |
|
I think it's because the git history on the dist files changed, there's probably a fancy way of fixing it via git but a quick and dirty fix would just be to download the dist files from the master repo and copy them into your branch, then git should detect that there are no changes. If you sync from the master branch where angular has been updated to 1.6, you'll see your demo doesn't work properly due to the upgrade. |
|
Released as 0.28.0, thanks for the contribution! |
Add a timePosition calendar attribute
Options: side, default or hidden
This new attribute allows configuring where the time should be positioned on the 'day view'.
side: on the side, outside of the calendar
hidden: kept out of sight; concealed ;)
default: on the inside of the calendar (any missing or unknown value will be interpreted as this option)