-
-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(day-view): prevent selection when dragging cal-event #521
Conversation
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 34 34
Lines 600 600
Branches 62 62
=======================================
Hits 580 580
Misses 1 1
Partials 19 19 Continue to review full report at Codecov.
|
Awesome, thank you! 😄 Will cut a patch release shortly with the fix |
Please note that commit did not fix issue. Several browsers require a prefix in order for the rule to be applied. See https://caniuse.com/#feat=user-select-none. 'user-select' only works on chrome AFAIK. |
FYI the prefix gets added at build time by auto-prefixer, if you check the dist files you'll see it there: https://unpkg.com/[email protected]/css/angular-calendar.css |
Ah that explains, sorry I didn't know. Still new to web dev :) |
Hi, I am not familiar with web dev neither, but using Firefox 61.0 64bits, the issue is not solved in the Kitchen Sink demo (neither on my app :'( ) |
Hey, running the latest version the issue is fixed. Are you sure you are running v0.25.2^? If that doesn't help, ensure |
Yes I am running the latest version : package.json -> "angular-calendar": "^0.25.2" |
Fixes issue where hour labels would be selected while dragging a day event.
The picture below demonstrates the issue reproduced on the official demo page.