Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(day-view): prevent selection when dragging cal-event #521

Merged
merged 2 commits into from
May 9, 2018
Merged

fix(day-view): prevent selection when dragging cal-event #521

merged 2 commits into from
May 9, 2018

Conversation

dwknippers
Copy link
Contributor

@dwknippers dwknippers commented May 3, 2018

Fixes issue where hour labels would be selected while dragging a day event.

The picture below demonstrates the issue reproduced on the official demo page.

image

@codecov-io
Copy link

codecov-io commented May 3, 2018

Codecov Report

Merging #521 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #521   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files          34       34           
  Lines         600      600           
  Branches       62       62           
=======================================
  Hits          580      580           
  Misses          1        1           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ce283...8e3f383. Read the comment docs.

@mattlewis92 mattlewis92 merged commit f799bf5 into mattlewis92:master May 9, 2018
@mattlewis92
Copy link
Owner

Awesome, thank you! 😄 Will cut a patch release shortly with the fix

@dwknippers
Copy link
Contributor Author

Please note that commit did not fix issue. Several browsers require a prefix in order for the rule to be applied. See https://caniuse.com/#feat=user-select-none. 'user-select' only works on chrome AFAIK.

@mattlewis92
Copy link
Owner

FYI the prefix gets added at build time by auto-prefixer, if you check the dist files you'll see it there: https://unpkg.com/[email protected]/css/angular-calendar.css

@dwknippers
Copy link
Contributor Author

Ah that explains, sorry I didn't know. Still new to web dev :)

@ahuetWL
Copy link

ahuetWL commented Jul 13, 2018

Hi, I am not familiar with web dev neither, but using Firefox 61.0 64bits, the issue is not solved in the Kitchen Sink demo (neither on my app :'( )
I probably did not undertsand what changes to apply to my code / browser, could you be more specific please ?
Thanks in advance !

@dwknippers
Copy link
Contributor Author

Hey, running the latest version the issue is fixed. Are you sure you are running v0.25.2^?
Try running npm install angular-calendar to update to the latest version.

If that doesn't help, ensure "angular-calendar": "^<version number>",
is within your package.json (note the "^").

@ahuetWL
Copy link

ahuetWL commented Jul 13, 2018

Yes I am running the latest version : package.json -> "angular-calendar": "^0.25.2"
And by "the Kitchen Sink demo" I mean the demo in the browser (accessible here), not one I could have copied on my computer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants