Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the tail of an event that spans across two days in monthly view changes the event source start. #746

Closed
daneshmandi opened this issue Sep 18, 2018 · 4 comments

Comments

@daneshmandi
Copy link

Describe the bug

Drag and dropping the tail of an event (that spans across two days ) in the same day in monthly view will changes the start and end of the source event.

Minimal reproduction of the problem with instructions

Consider you have an event that spans across two days. Fore instance the event starts at 2018/09/18 11:00 PM and will finish by 2018/09/19 03:00 AM. Then in the monthly view drag the tail part of the event that appears on 2018/09/19 and drop it again in the same day (2018/09/19). Then you would see that the event source will increment by one day. In this case, it will becomes 2018/09/19 11:00 PM to 2018/09/20 03:00 AM.

Screenshots

NA

Versions

  • @angular/core: 6.0.0
  • angular-calendar: 0.26.0
  • Browser name and version: Chrome 68.0.3440.106
@mattlewis92
Copy link
Owner

Thanks for reporting! Would you like to make a PR with a fix? If you add the day to the drop data here and then pass it to the drop event here you can check if the day it was dropped on and the day it was dragged from are different and if so then do nothing.

@daneshmandi
Copy link
Author

@mattlewis92 Sure! I would be glad to. Although I haven't done any Pull Request in github before.

@mattlewis92
Copy link
Owner

No worries, there's a great learning resource for it here: http://makeapullrequest.com/

@mattlewis92
Copy link
Owner

This should be fixed now in 0.26.2, thanks for reporting! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants