feat: remove the DragAndDropModule.forRoot method

BREAKING CHANGE: The `DragAndDropModule.forRoot` method was removed. To migrate just import the `DragAndDropModule` module directly
mattlewis92 · Jun 10, 2018 · 5ae52a7 · 5ae52a7
1 parent cf1bc61
commit 5ae52a7
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 22 deletions.
diff --git a/README.md b/README.md
@@ -14,11 +14,11 @@ https://mattlewis92.github.io/angular-draggable-droppable/demo/
 
 ## Table of contents
 
-* [About](#about)
-* [Installation](#installation)
-* [Documentation](#documentation)
-* [Development](#development)
-* [License](#licence)
+- [About](#about)
+- [Installation](#installation)
+- [Documentation](#documentation)
+- [Development](#development)
+- [License](#licence)
 
 ## About
 
@@ -40,7 +40,7 @@ import { DragAndDropModule } from 'angular-draggable-droppable';
 
 @NgModule({
   declarations: [DemoApp],
-  imports: [DragAndDropModule.forRoot()],
+  imports: [DragAndDropModule],
   bootstrap: [DemoApp]
 })
 class DemoModule {}
@@ -77,8 +77,8 @@ https://mattlewis92.github.io/angular-draggable-droppable/docs/
 
 ### Prepare your environment
 
-* Install [Node.js](http://nodejs.org/) and NPM (should come with)
-* Install local dev dependencies: `npm install` while current directory is this repo
+- Install [Node.js](http://nodejs.org/) and NPM (should come with)
+- Install local dev dependencies: `npm install` while current directory is this repo
 
 ### Development server
 

diff --git a/demo/demo.module.ts b/demo/demo.module.ts
@@ -5,7 +5,7 @@ import { DemoComponent } from './demo.component';
 
 @NgModule({
   declarations: [DemoComponent],
-  imports: [BrowserModule, DragAndDropModule.forRoot()],
+  imports: [BrowserModule, DragAndDropModule],
   bootstrap: [DemoComponent]
 })
 export class DemoModule {}
diff --git a/src/drag-and-drop.module.ts b/src/drag-and-drop.module.ts
@@ -1,17 +1,9 @@
-import { NgModule, ModuleWithProviders } from '@angular/core';
+import { NgModule } from '@angular/core';
 import { DraggableDirective } from './draggable.directive';
 import { DroppableDirective } from './droppable.directive';
-import { DraggableHelper } from './draggable-helper.provider';
 
 @NgModule({
   declarations: [DraggableDirective, DroppableDirective],
   exports: [DraggableDirective, DroppableDirective]
 })
-export class DragAndDropModule {
-  static forRoot(): ModuleWithProviders {
-    return {
-      ngModule: DragAndDropModule,
-      providers: [DraggableHelper]
-    };
-  }
-}
+export class DragAndDropModule {}
diff --git a/src/draggable-helper.provider.ts b/src/draggable-helper.provider.ts
@@ -1,5 +1,9 @@
 import { Subject } from 'rxjs';
+import { Injectable } from '@angular/core';
 
+@Injectable({
+  providedIn: 'root'
+})
 export class DraggableHelper {
   currentDrag: Subject<any> = new Subject();
 }
diff --git a/test/draggable.directive.spec.ts b/test/draggable.directive.spec.ts
@@ -40,7 +40,7 @@ describe('draggable directive', () => {
 
   beforeEach(() => {
     TestBed.configureTestingModule({
-      imports: [DragAndDropModule.forRoot()],
+      imports: [DragAndDropModule],
       declarations: [TestComponent]
     });
   });

diff --git a/test/droppable.directive.spec.ts b/test/droppable.directive.spec.ts
@@ -5,7 +5,6 @@ import * as sinon from 'sinon';
 import { triggerDomEvent } from './util';
 import { DragAndDropModule } from '../src/index';
 import { DraggableDirective } from '../src/draggable.directive';
-import { DroppableDirective } from '../src/droppable.directive';
 
 describe('droppable directive', () => {
   @Component({
@@ -55,7 +54,7 @@ describe('droppable directive', () => {
 
   beforeEach(() => {
     TestBed.configureTestingModule({
-      imports: [DragAndDropModule.forRoot()],
+      imports: [DragAndDropModule],
       declarations: [TestComponent]
     });
   });