fix: don't highlight text when dragging elements

Fixes #28
mattlewis92 · Jun 16, 2018 · 67d3a5e · 67d3a5e
1 parent bd25b99
commit 67d3a5e
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 6 deletions.
diff --git a/src/draggable.directive.ts b/src/draggable.directive.ts
@@ -9,7 +9,8 @@ import {
   OnDestroy,
   OnChanges,
   NgZone,
-  SimpleChanges
+  SimpleChanges,
+  Inject
 } from '@angular/core';
 import { Subject, Observable, merge } from 'rxjs';
 import {
@@ -23,6 +24,7 @@ import {
   filter
 } from 'rxjs/operators';
 import { DraggableHelper } from './draggable-helper.provider';
+import { DOCUMENT } from '@angular/common';
 
 export interface Coordinates {
   x: number;
@@ -150,12 +152,35 @@ export class DraggableDirective implements OnInit, OnChanges, OnDestroy {
     public element: ElementRef<HTMLElement>,
     private renderer: Renderer2,
     private draggableHelper: DraggableHelper,
-    private zone: NgZone
+    private zone: NgZone,
+    @Inject(DOCUMENT) private document: any
   ) {}
 
   ngOnInit(): void {
     this.checkEventListeners();
 
+    // hack to prevent text getting selected in safari while dragging
+    this.pointerDown.subscribe(() => {
+      const style: HTMLStyleElement = this.renderer.createElement('style');
+      this.renderer.setAttribute(style, 'type', 'text/css');
+      this.renderer.appendChild(
+        style,
+        this.renderer.createText(`
+          body * {
+           -moz-user-select: none;
+           -ms-user-select: none;
+           -webkit-user-select: none;
+           user-select: none;
+          }
+        `)
+      );
+      this.document.head.appendChild(style);
+
+      this.pointerUp.pipe(take(1)).subscribe(() => {
+        this.document.head.removeChild(style);
+      });
+    });
+
     const pointerDrag: Observable<any> = this.pointerDown.pipe(
       filter(() => this.canDrag()),
       mergeMap((pointerDownEvent: PointerEvent) => {
@@ -167,8 +192,6 @@ export class DraggableDirective implements OnInit, OnChanges, OnDestroy {
 
         const pointerMove: Observable<Coordinates> = this.pointerMove.pipe(
           map((pointerMoveEvent: PointerEvent) => {
-            pointerMoveEvent.event.preventDefault();
-
             return {
               currentDrag,
               x: pointerMoveEvent.clientX - pointerDownEvent.clientX,
@@ -220,8 +243,6 @@ export class DraggableDirective implements OnInit, OnChanges, OnDestroy {
         );
 
         dragStart$.subscribe(() => {
-          pointerDownEvent.event.preventDefault();
-
           this.zone.run(() => {
             this.dragStart.next({ x: 0, y: 0 });
           });

diff --git a/test/draggable.directive.spec.ts b/test/draggable.directive.spec.ts
@@ -58,6 +58,9 @@ describe('draggable directive', () => {
   afterEach(() => {
     fixture.destroy();
     document.body.innerHTML = '';
+    Array.from(document.head.getElementsByTagName('style')).forEach(style => {
+      document.head.removeChild(style);
+    });
   });
 
   it('should make the element draggable', () => {
@@ -618,4 +621,19 @@ describe('draggable directive', () => {
     expect((ghostElement as HTMLElement).hasAttribute('mwldraggable')).to.be
       .true;
   });
+
+  it('should make all elements on the page unable to select text while dragging', () => {
+    const tmp = document.createElement('div');
+    tmp.innerHTML = 'foo';
+    document.body.appendChild(tmp);
+    expect(getComputedStyle(tmp).userSelect).to.equal('auto');
+    const draggableElement: HTMLElement =
+      fixture.componentInstance.draggable.element.nativeElement;
+    triggerDomEvent('mousedown', draggableElement, { clientX: 5, clientY: 10 });
+    expect(getComputedStyle(tmp).userSelect).to.equal('none');
+    triggerDomEvent('mousemove', draggableElement, { clientX: 7, clientY: 10 });
+    expect(getComputedStyle(tmp).userSelect).to.equal('none');
+    triggerDomEvent('mouseup', draggableElement, { clientX: 7, clientY: 8 });
+    expect(getComputedStyle(tmp).userSelect).to.equal('auto');
+  });
 });