fix(draggable): fire dragEnd event when the event was not dragged

Fixes #17
mattlewis92 · Sep 18, 2017 · 73d65d7 · 73d65d7
1 parent b803096
commit 73d65d7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/draggable.directive.ts b/src/draggable.directive.ts
@@ -169,6 +169,8 @@ export class Draggable implements OnInit, OnChanges, OnDestroy {
           }
         });
 
+        this.pointerMove.next(pointerDownEvent);
+
         return pointerMove;
 
       })

diff --git a/test/draggable.directive.spec.ts b/test/draggable.directive.spec.ts
@@ -303,4 +303,13 @@ describe('draggable directive', () => {
     expect(fixture.componentInstance.draggable['eventListenerSubscriptions'].touchmove).to.equal(touchMoveUnsubscribe);
   });
 
+  it('should fire the dragEnd event when starting a drag but not actually moving it', () => {
+    const draggableElement: HTMLElement = fixture.componentInstance.draggable.element.nativeElement;
+    triggerDomEvent('mousedown', draggableElement, {clientX: 5, clientY: 10});
+    expect(fixture.componentInstance.dragStart).to.have.been.calledWith({x: 0, y: 0});
+    triggerDomEvent('mouseup', draggableElement, {clientX: 5, clientY: 10});
+    expect(fixture.componentInstance.dragEnd).to.have.been.calledWith({x: 0, y: 0});
+    expect(draggableElement.style.transform).not.to.be.ok;
+  });
+
 });