perf: only recompute draggable position on window scroll

mattlewis92 · Jun 17, 2018 · f6a5cde · f6a5cde
1 parent c5ef775
commit f6a5cde
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/droppable.directive.ts b/src/droppable.directive.ts
@@ -77,14 +77,21 @@ export class DroppableDirective implements OnInit, OnDestroy {
   ngOnInit(): void {
     this.currentDragSubscription = this.draggableHelper.currentDrag.subscribe(
       drag$ => {
+        let droppableRectangle = this.element.nativeElement.getBoundingClientRect();
+
+        /* istanbul ignore next */
+        this.renderer.listen('window', 'scroll', () => {
+          droppableRectangle = this.element.nativeElement.getBoundingClientRect();
+        });
+
         let currentDragDropData: any;
         const overlaps$ = drag$.pipe(
           map(({ clientX, clientY, dropData }) => {
             currentDragDropData = dropData;
             return isCoordinateWithinRectangle(
               clientX,
               clientY,
-              this.element.nativeElement.getBoundingClientRect()
+              droppableRectangle
             );
           })
         );