-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QGC 4.4 Issues List #11559
Comments
I've noticed hangs and crashes on both Mac OSX and Windows 11 when connected to a vehicle (real and SITL) via UDP |
I came across some other issues. The gimbal icon is missing in all of the v4.4 release candidates. I am using gremsy gimbal with cube orange px4 v1.14 |
@vacoff can you post a screenshot? @timtuxworth any chance you can give tips how to reproduce the crashes, or get crash reports? |
The only thing special I do is I usually use UDP to connect to my vehicles - this is usually SITL but I also do this with real planes. It's pretty easy. Just start QGC and use it for a bit. I run SITL for a while doing some testing. It will hang after a while and then you are forced to close it. I make sure to press the "report to Microsoft" button. You should be able to go to your Microsoft dev account and review the crash logs. Actually the same thing happens on my Mac too. It's very unstable it shouldn't be hard to reproduce. |
No idea how this would all connect. I rarely use Windows. That being said, I assume QGC v4.3.0 works nicely and doesn't have the stalls and crashes? |
I have no idea. I usually use the daily build which has always worked for me on both windows and Mac. |
I have not seen QGC 4.4 lockup or crash. This includes running it on Windows 11 using UDP or USB to real vehicles. @timtuxworth, could you just confirm that you're using QGC 4.4-rc3? If the crashing issue involves another version (like 4.5) I'd like it if we could move the discussion to another thread or issue so that we don't muddy the waters of the 4.4 beta testing. |
@rmackay9 I had a look through the issues you mentioned:
This one is tricky. I think it comes down to several points:
This would depend on the setup. It worked for me, although very slowly. And I'm not sure if it's the right way around. Could it be inverted? Maybe @Davidsastresas you can clarify: is it supposed to move with my finger? E.g. I point and move my finger the right and expect the camera to pan left?
I can confirm that. I'm not sure how to fix that one. @Davidsastresas hints would be appreciated.
This seemed correct with my testing with PX4. I'd check what's going on in: |
this screenshots are from release candidate 4.5 but the issue is still ongoing, even though the gimbal control works ok from both console and the rc input |
@vacoff ah, so the gimbal doesn't get detected in your case. Now I understand. What is the MNT_MODE_IN param set to? |
Hi @Davidsastresas, I think we should leave the click-and-drag in. I think it works unless there are two ground stations connected at which point they interfere with each other. I think it does no harm to leave it in. I vaguely remember (I think) that you said it was implemented using angle control, I think we should change that to use rate-control (which DO_GIMBAL_MANAGER_PITCHYAW supports) but I think we could do that for QGC-4.5. |
@vacoff I think I have found an edge case in PX4 that causes GIMBAL_MANAGER_INFORMATION not to be sent out and hence QGC not detecting the gimbal. I'll have a fix soon. |
@vacoff can you test with this PX4 branch: PX4/PX4-Autopilot#23236 |
it is set to mavlink v2 |
@julianoes just tested with the pr you said. GImbal icon is now appearing on the QGC but when I try to command it the error on the second picture is appearing. it is v4.4 rc5. It seems like it is stuck on the yaw follow mode and doesn't accept commands to change its mode also the on screen control doesn't work. it reacts to the "gimbal test" commands. btw I have changed hardware from cube orange to cuav nora as wouldn't like to fly with un-official firmware just to be safe. But I am not sure if this would make any difference. |
After rebooting the autopilot the gimbal manager command rejection error disappeared, but the whole logic of the commands on QGC is working kinda weird. For gimbal is on yaw follow mode in default. After pressing yaw lock it locks it in place until another command is activated such as center or tilt 90 degrees then it reverts to the yaw follow mode. And the yaw lock mode makes gimbal twitch in the yaw axis, it doesn't lock stable |
@vacoff I'm glad you got it to work (somewhat).
I think that's a gimbal issue. I'm assuming this is using the SIYI A8 mini? If so, I see the same.
That's by design. I don't think locking at 90 degrees down would make sense. And when you click center you want to have it look forward, so it shouldn't be locked anymore either. |
I am using Gremsy Mio. It seems like gimbal is switching between yaw lock and yaw follow modes fast, so it causes twitching. |
@vacoff that's interesting. Do you know what's sending it follow commands? |
@vacoff I verified this and I can't see the effect, at least when using PX4. It either sends with or without yaw lock. There is no switching between the two modes in my testing. Let me know if there is specific way to reproduce it . |
I have installed 4.4 on two Herelinks. The app seems to work well so far. |
@soleongmbh thanks for the report. We tested the HDMI functionality, so that's interesting. @rmackay9 do you remember what steps you took that fixed this? |
Hi @soleongmbh, I wonder if you're sure that switching between the streams worked before upgrading the herelink QGC firmware? There are instructions here for enabling two streams on the herelink https://docs.cubepilot.org/user-guides/herelink/herelink-faq#herelink-dual-video-instruction |
@julianoes on Herelink with "old" QGC the switching was working, it was really slow, but it was working. We use as pilot-cam the Hawkeye Firefly 4k split with setting "forced HDMI out" |
Hi @soleongmbh, I think I'll have to re-test but as far as I can remember, I did not actually have to follow the instructions that I linked above in order to enable two HDMI steams. The only caveat is that I think I only ever tested using one HDMI stream at a time. So I tested moving the same camera between the herelink's HDMI1 and HDMI2 inputs but maybe I never tested two cameras attached at the same time. |
Hi @rmackay9 , let me know if you want me to help with testing. It would be important that the switching between the streams works reliably. |
Hi @rmackay9 , Could you find the problem? Thank you! |
@soleongmbh did you ever get to the bottom of this? Or is switching still not working? |
Hi @julianoes , Unfortunately, switching between the two video streams is still not working. We have also tried different Herelinks. With the “old” QGC, the switching works, albeit slowly, but it works. |
These are Herelink 1.1 or 1.0 and updated AirUnits? |
@julianoes It was Herelink 1.0 with updated Airunits. |
Ok, I just tested the side loaded app using a Herelink 1.0 with Airunit also at 1.0 both updated and I can switch HDMI with the stock QGC app, as well as the v4.4.0 release. Not sure what else to try. @soleongmbh maybe you can provide some screenshots or a video to demonstrate what you're doing, and make sure to check your version as well. |
@soleongmbh the latest to check would be https://github.com/CubePilot/qgroundcontrol-herelink, just building right now. |
@julianoes I installed the 4.4.2 version on Herelink. here you can find the information abiout the version of Herelink and Airunit and two videos:
|
@soleongmbh thanks for this, so I'm watching 20240906_171354-QGC-4.4.2: 0:52: switch to HDMI1 worked I was under the impression that it doesn't work at all for you but it looks like it doesn't work consistently, or maybe only in the beginning? Do I get that right? One more note. I see the progress bar at the top doesn't finish, which presumably means the parameter loading doesn't complete. I wonder if there is something else going on that interferes with the communication or logic and the side effect is that HDMI switching isn't reliable. |
@julianoes Je, you are right. it works a few times at the beginning and then no more. Once it stops working, I have to powercycle the drone and the Herelink to make it work again. Loading the parameters should not be a problem for my understanding, if the switching works with the old QGC, then it should also work with the new QGC. I wonder if the switching works for you several times and without problems? |
@soleongmbh I think what Julian meant is that your param bar indicates for some reason you are having mavlink traffic issues, and that indeed messes with video switching, because video switching uses the same mavlink channel. Even if you have control and see telemetry alright, if the link isn't ideal or if it is overloaded for some reason, those video switching commands could get lost. I remember somewhere you mentioned you were doing something custom involving custom mavlink on your setup, so I wonder if some part of your system could be using too much mavlink bandwidth, which could be messing with your param download and also with particular commands like video switching. At this point, I think your best bet is to try to troubleshoot that, or try to find more users that report the same error. Not saying there isn't an error or bug, but nobody has confirmed your findings yet. |
@soleongmbh I think I can reproduce the issue. It seems to get in a state where it is out of sync, thinking it's showing HDMI2 but falling back to HDMI1 somehow. I will have to have a closer look. @Davidsastresas one thing I see is that we might need to use command retransmission here: |
@julianoes Yesterday I tested again with another system where there is no problem with the Mavlink traffic. Also to clarify this doubt.
Link Videos: https://www.dropbox.com/scl/fo/bt5fgma57dzi7u1gk30lm/AHcKDlsZYWRJ8iuhCsMMoSY?rlkey=m9ar9ek4nu3eclsfus2mgo8n1&dl=0 |
Happy to hear you reproduced it @julianoes . It might be related to the fact that we are not using the feedback from Airunit in QGC 4.4 because we decided to leave that out due to Cubepilot using custom mavlink for this matter, so in QGC 4.4 that is working in "open loop". Is that why you suggested to implement retransmission there? |
Right, so I'm just wondering if we somehow get out of sync because we don't have feedback and only try once. I'll have to dig deeper. Planning to do that in the next few days. |
@soleongmbh sorry it took a while, I finally got around and good look closer at the HDMI switching issue. A fix is coming soon: CubePilot/qgroundcontrol-herelink#57 |
@julianoes should I look into that fix in master as well? I assume it's relevant to all platforms not just herelink |
@julianoes thank you for the info, if you need help in testing, please let me know if I can help with testing. |
@julianoes What's the state of the Cubepilot herelink repo? Is that still the really old build or is it based on my repo now? |
@DonLakeFlyer this is the current v4.4.3 herelink repo, it's a few commits on top of v4.4.3 upstream: The main thing that can't use custom is switching HDMI, as described here: |
BTW, the Herelink is still shipping with a really old version of QGC but I heard from Sid that they had it in their project plans to update it to the latest version. I'll give them another ping about that. We have instructions here on the AP wiki about how to update to the 4.4 version. As a side note I wonder what our plans are for beta testing and releasing the next stable version of QGC based on daily/latest. Maybe this isn't the place to discuss that but I just want to say that I'm more than happy to help with the beta testing similar to what we did for 4.4 |
That would be up to me to get done. One issue is that v4.4.3 doesn't have feature parity with the stock version, so it's not option to roll it out as is. The other tricky bit is the mess where the MAVLink message was changed, and so we have to careful in how to roll this out without causing things to break. I'll bring it up again and talk it through with Sid. Regarding the next version, it might be a good idea that we have a chat together with @DonLakeFlyer and @HTRamsey. |
Regarding the new QGC stable, I think were getting closer to that. I just ran into a bit of a roadblock on the daily build version of Herelink. My Herelink seems to have crapped out. Do you guys know someone I can ping other than Philip to try to help with resurrecting it? Screen started flashing then it seems to have crashed. And now I can't restart it. I was working on getting that finished up and working with all the new cmake stuff. Still more custom build cmake work to be done there. |
Nevermind. It seems to have magically resurrected itself after sitting for a couple hours! |
@DonLakeFlyer, Great that it's sorted. In general Sid is the one we normally talk to about hardware support for devs. |
This is a consolidated list of issues related to the 4.4 beta release.
Reports requiring investigation:
Confirmed issues:
Enhancements or Issues that may not be resolved before the stable release:
Resolved issues:
The text was updated successfully, but these errors were encountered: