Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Fix failing async test #6

Closed
maxdeviant opened this issue Oct 24, 2016 · 3 comments
Closed

Fix failing async test #6

maxdeviant opened this issue Oct 24, 2016 · 3 comments

Comments

@maxdeviant
Copy link
Owner

Currently the tests for the async functionality (added in #5) are failing, as noted in this comment:

Also, as you might have noticed, the test for the async way was failing. I've wrapped the stream in a promise that will resolve with the completed string when it's ready. But still the encryption test passes and decryption fails. I think the encryption is passing only due to the test state object being really small and it manages to resolve before expect() starts working.

These should be fixed.

@sibelius
Copy link

is this still a thing?

@maxdeviant
Copy link
Owner Author

@sibelius Yes, this test is still commented out because it's failing.

I don't think it's the test that's bad but rather we need to take a look at how the async functionality is implemented.

@maxdeviant
Copy link
Owner Author

Asynchronous support has been removed in #47.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants