Hide "Database up to date" messages behind verbose #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's expected that many (if not most) will run geoipupdate from cron, so normal operation likely shouldn't produce any output. When the database is updated, no output is produced unless verbose is enabled. However, when no update is available, a message is produced regardless of verbosity. Make the output consistent by guarding "Database %s up to date" behind a verbose check.
oschwald
approved these changes
Apr 13, 2023
|
Thank you! |
oschwald
added a commit
that referenced
this pull request
Apr 13, 2023
oschwald
added a commit
that referenced
this pull request
Apr 13, 2023
5.0.2 * "Database ... up to date" messages are now only shown if the verbose flag is set. Pull request by Adam Weinberger. GitHub #219.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's expected that many (if not most) will run geoipupdate from cron, so normal operation likely shouldn't produce any output.
When the database is updated, no output is produced unless verbose is enabled. However, when no update is available, a message is produced regardless of verbosity.
Make the output consistent by guarding "Database %s up to date" behind a verbose check.