Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler setting NO_BROWSER=1 is ignored #229

Open
Bec-k opened this issue Aug 21, 2021 · 7 comments
Open

Compiler setting NO_BROWSER=1 is ignored #229

Bec-k opened this issue Aug 21, 2021 · 7 comments

Comments

@Bec-k
Copy link

Bec-k commented Aug 21, 2021

I have found same version of emscripten and managed to re-compile, but it seems that NO_BROWSER=1 setting is ignored and compiled code have Browser object inside.

How did you manage to compile without it?

@soliton4
Copy link
Collaborator

the compiler parameters do not reflect 100% what is neccessary to build broadway. they are the resulot of trial and error where a functional broadway reflects success and faster running broadway beats a slower one.

the parameters also change over time as you pointed out. i believe it is a relict from a time where i compiled the webworker version seperately.

i recommend using the latest emscripten version and fine tunining it yourself if you are into that. you may get a few % performance out of it.

let us know you results pleas

@Bec-k
Copy link
Author

Bec-k commented Aug 23, 2021

When i'm trying to pipe h.264 baseline video stream from camera over RTSP and -c copy -f rawvideo via ffmpeg, it is complaining about memory on browser side, that's why i have tried to recompile it with higher memory limit, but it was not reacting to that setting...
I just kept re-encoding on ffmpeg side without -c copy and it is working fine now. I kept it like that, no time to invest into new version of emscripten right now, maybe i'll research that area later.
Anyway, thank you for your stuff, it is still working like a charm, over so much years 👍

@soliton4
Copy link
Collaborator

you could try to use
ALLOW_MEMORY_GROWTH=1

see if that changes your memory issues. i dont recommend using that parameter for the final version as i belive it has performance compromises. but its worth investigating

https://emscripten.org/docs/optimizing/Optimizing-Code.html

@Bec-k
Copy link
Author

Bec-k commented Aug 29, 2021

I tried to compile and remove Browser variables manually, video wasn't decoded properly and no error was thrown.
Maybe there is some debugging mode both from WASM side and on js side? I could post the output here.

@soliton4
Copy link
Collaborator

@myjimmy sorry i am not working full time on broadway. just got back to it
compile broadway with higher memory setting and you should be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@soliton4 @Bec-k and others