Discord Server Stop Notification No Longer Being Sent

[nevrending]

Hello all,

After updating to the latest container version, seems like server stop notifications are no longer being sent to Discord.
Last time we played was about 6 month-ish ago and has recently got back after the DLC release.
We are running using docker stacks and only did docker pull to get the latest image version.

Server start notifications kept being sent as normal.

Stop log

2022-12-09T20:41:29.322687998Z [Valheim][steam]: Halting server! Received interrupt!
2022-12-09T20:41:29.339052236Z [ODIN][INFO]  - Stopping server /home/steam/valheim
2022-12-09T20:41:29.346327120Z [ODIN][INFO]  - Scanning for Valheim process
2022-12-09T20:41:29.348113397Z [ODIN][INFO]  - Found Process with pid 173! Sending Interrupt!
2022-12-09T20:41:29.348125259Z [ODIN][INFO]  - Process signal interrupt sent successfully!
2022-12-09T20:41:29.461993270Z 12/10/2022 07:41:29: Game - OnApplicationQuit
2022-12-09T20:41:29.462009951Z 12/10/2022 07:41:29: Shuting down
2022-12-09T20:41:29.462632523Z 12/10/2022 07:41:29: ZNet Shutdown
2022-12-09T20:41:30.951609785Z 12/10/2022 07:41:30: clone 1488
2022-12-09T20:41:30.961745675Z 12/10/2022 07:41:30: World save writing starting
2022-12-09T20:41:30.963980883Z 12/10/2022 07:41:30: World save writing started
2022-12-09T20:41:33.679135641Z 12/10/2022 07:41:33: Saved 1108214 zdos
2022-12-09T20:41:33.689312628Z 12/10/2022 07:41:33: World save writing finishing
2022-12-09T20:41:33.809715910Z 12/10/2022 07:41:33: World save writing finished
2022-12-09T20:41:33.819235510Z 12/10/2022 07:41:33: Considering autobackup. World time: 248.06, short time: 7200, long time: 43200, backup count: 4
2022-12-09T20:41:33.819256419Z 12/10/2022 07:41:33: Skipping backup. World session not long enough.
2022-12-09T20:41:33.827511851Z 12/10/2022 07:41:33: World saved ( 2865.086ms )
2022-12-09T20:41:33.827552285Z 12/10/2022 07:41:33: Considering autobackup. World time: 248.06, short time: 7200, long time: 43200, backup count: 4
2022-12-09T20:41:33.827558327Z 12/10/2022 07:41:33: Skipping backup. World session not long enough.
2022-12-09T20:41:34.194987221Z 12/10/2022 07:41:34: Sending disconnect msg
2022-12-09T20:41:34.195595988Z 12/10/2022 07:41:34: Disposing socket
2022-12-09T20:41:34.196197001Z 12/10/2022 07:41:34: Stopping listening socket
2022-12-09T20:41:34.196637727Z 12/10/2022 07:41:34: Last socket, unregistering callback
2022-12-09T20:41:34.196755485Z 12/10/2022 07:41:34: ZSteamSocket  UnregisterGlobalCallbacks, existing sockets:0
2022-12-09T20:41:36.216370350Z Setting up 2 worker threads for Enlighten.
2022-12-09T20:41:36.216895913Z   Thread -> id: 7f0afffff700 -> priority: 1 
2022-12-09T20:41:36.216948300Z   Thread -> id: 7f0afeffd700 -> priority: 1 
2022-12-09T20:41:38.701853897Z 12/10/2022 07:41:38: Steam manager on destroy
2022-12-09T20:41:39.042994078Z 12/10/2022 07:41:39: ZNet OnDestroy
2022-12-09T20:41:39.044385995Z 12/10/2022 07:41:39: Net scene destroyed

Start log

[Valheim][steam]: Starting server...
[ODIN][INFO]  - Setting up start scripts...
[ODIN][INFO]  - Looking for burial mounds...
[ODIN][INFO]  - Server has been started and Daemonized. It should be online shortly!
[ODIN][INFO]  - Keep an eye out for 'Game server connected' in the log!
[ODIN][INFO]  - Starting web server....
[ODIN][INFO]  - Navigate to http://127.0.0.1:8080/status to view the server status.
[ODIN][INFO]  - Server::run; addr=0.0.0.0:8080
[ODIN][INFO]  - listening on http://0.0.0.0:8080
[ODIN][INFO]  - Sending discord notification <3
[ODIN][INFO]  - [Start Successful]: Webhook message sent successfully!
[ODIN][INFO]  - (this indicates its online without any errors.)

Any ideas where I should start looking at/for? Thanks!

[mbround18]

@nevrending is the stop message not showing up in discord? i might have to take a gander at the code again, ill take a look tomorrow :)

[mbround18]

I believe this has been fixed in v2 @nevrending could you give it a whirl?

[jbarnes]

I believe this is still not functional running v2, the started messages still come through, nothing for stopped.

[mbround18]

@jbarnes created issue #671 and will tackle this week

[mbround18]

Ahh i found it, in my refactor i forgot to include the notification