From 435739d1fd171c0c86e9bb8ff1947889d398fc91 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathias=20=C3=85hsberg?= Date: Mon, 27 Apr 2020 11:21:49 +0000 Subject: [PATCH] Add check if Code Insights is available --- .../BitbucketServerPullRequestDecorator.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/bitbucket/BitbucketServerPullRequestDecorator.java b/src/main/java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/bitbucket/BitbucketServerPullRequestDecorator.java index 4b2dd8be..30d5a35e 100644 --- a/src/main/java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/bitbucket/BitbucketServerPullRequestDecorator.java +++ b/src/main/java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/bitbucket/BitbucketServerPullRequestDecorator.java @@ -82,13 +82,13 @@ public String name() { return "BitbucketServer"; } - public boolean isEnabled() { - return client.isConfigured() && client.supportsCodeInsights(); - } - @Override public void decorateQualityGateStatus(AnalysisDetails analysisDetails, UnifyConfiguration configuration) { try { + if(!client.supportsCodeInsights()) { + LOGGER.warn("Your Bitbucket instances does not support the Code Insights API."); + return; + } String project = configuration.getRequiredProperty(PULL_REQUEST_BITBUCKET_PROJECT_KEY); String repo = configuration.getRequiredProperty(PULL_REQUEST_BITBUCKET_REPOSITORY_SLUG); @@ -210,7 +210,10 @@ private ReportData maintainabilityReport(Long codeSmells) { private String reportDescription(AnalysisDetails details) { String header = details.getQualityGateStatus() == QualityGate.Status.OK ? "Quality Gate passed" : "Quality Gate failed"; - String body = details.getFailedConditions().stream().map(AnalysisDetails::format).map(s -> format("- %s", s)).collect(Collectors.joining("\n")); + String body = details.getFailedConditions().stream() + .map(AnalysisDetails::format) + .map(s -> format("- %s", s)) + .collect(Collectors.joining("\n")); return format("%s%n%s", header, body); }