Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR decoration BBserver - size on screen #204

Closed
tomki99 opened this issue Jul 10, 2020 · 4 comments
Closed

PR decoration BBserver - size on screen #204

tomki99 opened this issue Jul 10, 2020 · 4 comments
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@tomki99
Copy link

tomki99 commented Jul 10, 2020

Describe the bug
Two issues:

PR decoration (BitBucket server) produces a feedback on the BitBucket pull request page with Analysis Details. Unfortunately the message from SonarQube occupies whole screen and after few updates to the PR it becomes unreadable. The problem is the messages have big "icons" (white squares) which causes to be the message so long.

At the end of the message a link http://localhost:9000/dashboard?id=project&pullRequest=1 appears which directs to the server of bitbucket while (in our case, any probably not only our) the sonarqube is located on different host.

To Reproduce
Steps to reproduce the behavior:

  1. BB server v7.2.2
  2. SonarQube 7.9.3 (LTS)
  3. sonarqube-community-branch-plugin-1.3.0

Expected behavior

  1. The "icons" are not higher than fonts or can be disabled/customized
  2. The links points to the actual sonarqube server

comm-branch-plugin-issues

@tomki99 tomki99 added the bug Something isn't working label Jul 10, 2020
@goober
Copy link
Contributor

goober commented Jul 10, 2020

This should have been fixed in the master branch by #151

@tomki99
Copy link
Author

tomki99 commented Jul 15, 2020

Indeed after upgrade to 1.3.1 it seems much better. It's now separated sub-page which is very useful.
1 3 1-PRdecoration2

Unfortunately two links
View report and Go to SonarQube on the new result page are still fixed to localhost.
http://localhost:9000/dashboard?id=PoC&pullRequest=9

1 3 1-PRdecoration

@mc1arke
Copy link
Owner

mc1arke commented Jul 15, 2020

The URLs are driven by the configuration you've put into Sonarqube for what your server base URL is, and this value defaults to localhost if you've not set it otherwise. An administrator needs to set the Server Base URL value under Administration > Configuration > General settings to the correct URL for your Sonarqube instance.

@mc1arke mc1arke added the invalid This doesn't seem right label Jul 15, 2020
@tomki99
Copy link
Author

tomki99 commented Jul 16, 2020

Indeed it was not configured. After doing that, the links are correct.

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants