AzureDevops PR Decoration - comments in PR are not closed

[bambuca]

Describe the bug
Some comments remain active in AzureDevops PR, although they are marked as closed in the sonar.
These issues are in sonar twice.

To Reproduce
Steps to reproduce the behavior:
I'm not entirely sure, but I'd say the problem occurs when the pipeline starts in AzureDevops, but before it finish, the programmer make a push with some SQ issues fixes. This cancels the running pipeline and starts a new one. After that the fixed issues are not closed in PR.

1. Create PR with issues
2. Sonnar will create comments in PR
3. Push commit to Azure
4. Azure trigger PR validation pipeline
5. Push commit to Azure with fix of some issues (maybe you have to wait until "Prepare Analysis Configuration" finish, but before "Run Code Analysis" task start.
6. Azure cancels pipeline from step 4 and trigger new one
7. Issue is closed in sonar but not in Azure

Expected behavior
I expect that corresponding thread in PR will be closed.

Screenshots
If applicable, add screenshots to help explain your problem.

Software Versions

• SonarQube Version: 8.4.2.36762 in docker
• Plugin Version: 1.5.0

Additional context
Add any other context about the problem here.

[bambuca]

I tried to simulate the error again, but without success. So the problem still exists, but I don't know how to simulate it.
I'll leave the TRACE log enabled and when the problem reappears, I'll check the log and upload it here.

[bambuca]

The comments remains active in PR when the source file is removed.
AzureDevops

SonarQube:

[mc1arke]

I believe this is fixed by the second commit in #391 . Are you able to test out a snapshot of that build and provide feedback?

[mc1arke]

Released in v1.9.0 of the plugin

[mc1arke]

Backported to 1.8.1 of the plugin for Sonaqube 8.9.