Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Devops: mono repo support #361

Closed
axylophon opened this issue May 21, 2021 · 5 comments
Closed

Azure Devops: mono repo support #361

axylophon opened this issue May 21, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@axylophon
Copy link

Hi,

are mono repos supported with this plugin?
We have .NET and Angular projects mixed in a single repository. If we create a PR are the comments and the quality gate then merged when consecutive sonar analysis are executed in separate pipelines?

I see a merged PR with the issue #213. But this is only for GitHub,

Thank you!

@mc1arke
Copy link
Owner

mc1arke commented May 21, 2021

No, the analysis name would currently clash between different runs in Azure so overwrite the existing pipeline. The existing change should be easy to extend to cover all decorators though.

@mc1arke mc1arke added the enhancement New feature or request label May 21, 2021
@axylophon
Copy link
Author

Thank you for your response!

If the project name is added like in the Github solution, this would potentially break existing DevOps builds, as the name of the StatusCheck in DevOps is modified.
Would this be acceptable?

@mc1arke
Copy link
Owner

mc1arke commented Jul 25, 2021

Yes, if the project is configured to depend on a status check with a particular name then renaming the Status Check will cause problems, however without having checks named differently then there's no way to support monorepos. I've implemented my proposed approach in #391, could you take a look and provide any feedback please?

@axylophon
Copy link
Author

Hi thank you for your work it is highly appreciated!
The refactoring looks good to me.

@mc1arke
Copy link
Owner

mc1arke commented Sep 1, 2021

Released in 1.9.0 and 1.8.1

@mc1arke mc1arke closed this as completed Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants