Approve PR that passed quality gate

[artemy-osipov]

This feature will allow to configure the PR to make it required to pass the quality gate. It is only necessary to add a comment user to the required reviewers.

[artemy-osipov]

@mc1arke I'm going to implement this feature for Bitbucket Server. Is it better to use the master or branch from #58 (sonar 8.1) as a base branch?

[mc1arke]

I'm going to merge #58 once I've got it up-to-date and made sure things still work, but I'd suggest you stick with master for now. What I'm likely to do is create a maintenance branch from the 1,3,0 tag, try and get any features working on there initially and then cherry-pick them across onto master. If you start from current master then you'll just need to change the target branch rather than deal with any conflicts if we try and backport having built from 8.1 originally.

[rpo-fr]

Hi,
Perhaps it works on bitbucket server with code insight configuration, but on bitbucket cloud, we can't restrict PR merge when quality gate not passed.
Implementing PR approve could help us to do this

[nfalco79]

On bitbucket cloud PR approval restrict merge action if you have premium account (like us).
Anyway it's a good approace. We had sonarqube LTS 6.7 and mibexsoftware plugin 3 mounth ago and than update to TLS 8.7. The approval of builder user it's a common useful practic that it's better than have a failed bitbucket report that does not play any role in merge restriction.

[floriankraemer]

Is there a way to approve a non passing quality gate for Gitlab as well?

[mc1arke]

No, there is no functionality in the plugin to approve MR/PRs