From 970e3e6cb7da023d35b00ec23613168c971434ad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micka=C3=ABl=20Can=C3=A9vet?= <mickael.canevet@gmail.com>
Date: Wed, 23 Jun 2021 07:16:39 +0200
Subject: [PATCH] feat: upgrade ArgoCD to 2.0.4

Note: thanks to https://github.com/argoproj/argo-cd/pull/6402, it's not
required anymore to retry.
---
 .github/workflows/terraform.yml | 6 +++---
 .gitlab-ci/pipeline.yaml        | 2 +-
 modules/argocd-helm/main.tf     | 4 +---
 modules/values.tmpl.yaml        | 3 +++
 4 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/terraform.yml b/.github/workflows/terraform.yml
index 84a0c7762c..680c5356c7 100644
--- a/.github/workflows/terraform.yml
+++ b/.github/workflows/terraform.yml
@@ -37,7 +37,7 @@ jobs:
       - name: Setup ArgoCD
         run: |
           mkdir "$GITHUB_WORKSPACE/bin"
-          curl -L https://github.com/argoproj/argo-cd/releases/download/v2.0.3/argocd-linux-amd64 > "$GITHUB_WORKSPACE/bin/argocd"
+          curl -L https://github.com/argoproj/argo-cd/releases/download/v2.0.4/argocd-linux-amd64 > "$GITHUB_WORKSPACE/bin/argocd"
           echo "$GITHUB_WORKSPACE/bin" >> $GITHUB_PATH
           chmod +x "$GITHUB_WORKSPACE/bin/argocd"
 
@@ -111,7 +111,7 @@ jobs:
       - name: Setup ArgoCD
         run: |
           mkdir "$GITHUB_WORKSPACE/bin"
-          curl -L https://github.com/argoproj/argo-cd/releases/download/v2.0.3/argocd-linux-amd64 > "$GITHUB_WORKSPACE/bin/argocd"
+          curl -L https://github.com/argoproj/argo-cd/releases/download/v2.0.4/argocd-linux-amd64 > "$GITHUB_WORKSPACE/bin/argocd"
           echo "$GITHUB_WORKSPACE/bin" >> $GITHUB_PATH
           chmod +x "$GITHUB_WORKSPACE/bin/argocd"
 
@@ -171,7 +171,7 @@ jobs:
 
       - name: ArgoCD app diff with ${{ github.ref }}
         id: app-diff
-        uses: docker://argoproj/argocd:v2.0.3
+        uses: docker://argoproj/argocd:v2.0.4
         env:
           KUBECONFIG: ${{ github.workspace }}/kubeconfig
           APP_OF_APPS_VALUES_0 : ${{ github.workspace }}/values0.yaml
diff --git a/.gitlab-ci/pipeline.yaml b/.gitlab-ci/pipeline.yaml
index d48cc4dacf..739d6e24fa 100644
--- a/.gitlab-ci/pipeline.yaml
+++ b/.gitlab-ci/pipeline.yaml
@@ -1,6 +1,6 @@
 ---
 variables:
-  ARGOCD_VERSION: "2.0.3"
+  ARGOCD_VERSION: "2.0.4"
   TERRAFORM_VERSION: "1.0.0"
   CAMPTOCAMP_DEVOPS_STACK_VERSION: "0.38.0"
   TF_ROOT: terraform
diff --git a/modules/argocd-helm/main.tf b/modules/argocd-helm/main.tf
index 0d1ec4318f..263de73da2 100644
--- a/modules/argocd-helm/main.tf
+++ b/modules/argocd-helm/main.tf
@@ -124,9 +124,7 @@ resource "null_resource" "wait_for_app_of_apps" {
     KUBECONFIG=$(mktemp /tmp/kubeconfig.XXXXXX)
     echo "$KUBECONFIG_CONTENT" > "$KUBECONFIG"
     export KUBECONFIG
-    for i in `seq 1 60`; do
-      argocd app wait apps --sync --health --timeout 30 && rm "$KUBECONFIG" && exit 0
-    done
+    argocd app wait apps --sync --health --timeout 1800 && rm "$KUBECONFIG" && exit 0
     echo TIMEOUT
     rm "$KUBECONFIG"
     exit 1
diff --git a/modules/values.tmpl.yaml b/modules/values.tmpl.yaml
index 948a076a71..d52f2ff676 100644
--- a/modules/values.tmpl.yaml
+++ b/modules/values.tmpl.yaml
@@ -54,6 +54,9 @@ ${yamlencode({"extraApplicationSets": extra_application_sets})}
 
 argo-cd:
   installCRDs: false
+  global:
+    image:
+      tag: "v2.0.4"
   configs:
     secret:
       argocdServerAdminPassword: "$2a$10$wzUzrdx.jMb7lHIbW6VutuRpV4OnpPA3ItWBDiP04QVHfGqzAoj6i"  # argocd