Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REJOIN code and logic is pre-LoRaWAN, should come out #165

Closed
terrillmoore opened this issue Oct 28, 2018 · 2 comments
Closed

REJOIN code and logic is pre-LoRaWAN, should come out #165

terrillmoore opened this issue Oct 28, 2018 · 2 comments
Assignees

Comments

@terrillmoore
Copy link
Member

All of the logic related to HDR_FTYPE_REJOIN is obsolete. That header type didn't make it into the 1.0.2 spec. Remove HDR_FTYPE_REJOIN, all uses of OP_REJOIN, the API LMIC_tryRejoin().

@terrillmoore
Copy link
Member Author

terrillmoore commented Nov 10, 2018

It turns out, after studying the code some more, that OP_REJOIN is not obsolete, even though HDR_FTYPE_REJOIN is. In the LMIC code, a rejoin is a "make before break" join and is used for several purposes (particularly in ADR recovery when we've seen nothing for quite a while). So although we should change joins that are triggered by OP_REJOIN to use HDR_FTYP_JREQ, we should not remove the concept.

In addition, the rejoin request is sent using the datarate suggested by the LMIC normal transmission logic. It's not clear that this is right; I think join requests now should be sent at the network-defined rate. Review this when removing HDR_FTYPE_REJOIN.

@terrillmoore
Copy link
Member Author

With the changes from #275, #276, #278, I think we're ready to use this properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant