Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radio.c uses SX1272_MC1_IMPLICIT_HEADER for the 1276 #252

Closed
terrillmoore opened this issue Mar 17, 2019 · 1 comment
Closed

radio.c uses SX1272_MC1_IMPLICIT_HEADER for the 1276 #252

terrillmoore opened this issue Mar 17, 2019 · 1 comment
Assignees
@terrillmoore
Labels
bug

Comments

@terrillmoore
Copy link
Member

terrillmoore commented Mar 17, 2019 •
edited
Loading

The LMIC.dataLen value is using the following code:

arduino-lmic/src/lmic/radio.c

Lines 972 to 973 in 4eebb4a

LMIC.dataLen = (readReg(LORARegModemConfig1) & SX1272_MC1_IMPLICIT_HEADER_MODE_ON) ?
readReg(LORARegPayloadLength) : readReg(LORARegRxNbBytes);

Unfortunately, SX1272_MC1_IMPLICIT_HEADER_MODE_ON is the wrong bit for the 1276...
@terrillmoore terrillmoore self-assigned this Mar 17, 2019
@terrillmoore
Copy link
Member Author

Committing as part of #215.

@terrillmoore terrillmoore mentioned this issue Mar 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrillmoore terrillmoore

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrillmoore