Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance test needs clock tolerance of 5% #259

Open
terrillmoore opened this issue Mar 18, 2019 · 1 comment
Open

Compliance test needs clock tolerance of 5% #259

terrillmoore opened this issue Mar 18, 2019 · 1 comment
Assignees

Comments

@terrillmoore
Copy link
Member

In working on #215 and preparing to merge, I found that a clock tolerance of zero is just too tight; empirically I found that a tolerance of 5% was adequate. Added to the test script by 1b463a3, but I wonder if we should really default to 5% in the LMIC code.

@terrillmoore
Copy link
Member Author

In chasing the remaining FSK issues, I tried turning off clock tolerance in the compliance script, and things worked much better for RX1. RX2, it’s not clear. But rather than starting before the RX2 window, the lmic starts a little later, at about 2.01 sec. RX1 starts consistently at 999. Curious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant