-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encode date is null fix #85
Conversation
Referring to the issue I submitted :D I am running an auto script testing framework and found out it might be a bug in encoder.js: it's when encoderDate's argument is null, it throws exceptions so could a condition to avoid this. Can you verify if it's a potential bug? it would be helpful for my experiment:) function encodeDate (dt) { if (nanos || seconds > 0xFFFFFFFF) { |
there seems to be linting errors: https://travis-ci.org/github/mcollina/msgpack5/jobs/744518226 |
It seems to be a problem with my format. I fixed it. |
Can you please add a unit test? |
Hi, I have added a unit test for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, a could of nits.
lib/codecs/DateCodec.js
Outdated
if (dt === null) { | ||
return | ||
} | ||
// zhe-li fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why these comments? can you remove them?
@@ -0,0 +1,12 @@ | |||
var test = require('tape').test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'use strict'
is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fix all that:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.