Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/repo updates #189

Merged
merged 10 commits into from
Oct 24, 2024
Merged

Feature/repo updates #189

merged 10 commits into from
Oct 24, 2024

Conversation

adraismawur
Copy link
Collaborator

@adraismawur adraismawur commented Oct 4, 2024

This PR adds a docker file, re-adds the license, adds installation through hatch and updates the readme.

As a small side-effect of wanting to use docker, I have also updated the python version. This can probably be reverted if we really need to.

@adraismawur adraismawur self-assigned this Oct 4, 2024
@adraismawur adraismawur requested review from CatarinaCarolina and nlouwen and removed request for CatarinaCarolina October 8, 2024 08:02
@adraismawur
Copy link
Collaborator Author

There is still the possibility of adding a helper script to run things through docker. The command is not too far-fetched in my opinion, but then again I know how to use docker.

Copy link
Collaborator

@CatarinaCarolina CatarinaCarolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we're here, could you also update the authors and maintainers list :)

Copy link
Collaborator

@nlouwen nlouwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for now, remember to update the docker link and source code branch whenever v2 release is finalized

@adraismawur adraismawur merged commit 6dc5113 into dev Oct 24, 2024
7 checks passed
@adraismawur adraismawur deleted the feature/repo-updates branch November 7, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants