Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-implement (?) disk-only database #191

Merged
merged 6 commits into from
Oct 14, 2024
Merged

re-implement (?) disk-only database #191

merged 6 commits into from
Oct 14, 2024

Conversation

adraismawur
Copy link
Collaborator

This implements disk-only database functionality. This works on my machine ™️ but there may be issues with this on mac since it can affect multiprocessing which has its share of platform difference issues.

@adraismawur adraismawur requested a review from nlouwen October 8, 2024 08:06
@adraismawur adraismawur self-assigned this Oct 8, 2024
Copy link
Collaborator

@CatarinaCarolina CatarinaCarolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs validations to handle --no-db-dump and --disk-only being provided at the same time

@adraismawur
Copy link
Collaborator Author

This now has parameter validation checking.

Copy link
Collaborator

@CatarinaCarolina CatarinaCarolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adraismawur adraismawur merged commit 0f35ec0 into dev Oct 14, 2024
4 checks passed
@adraismawur adraismawur deleted the hotfix/disk-only-db branch October 21, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants