Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add include and exclude classes/categories filter #203

Merged
merged 5 commits into from
Nov 1, 2024
Merged

add include and exclude classes/categories filter #203

merged 5 commits into from
Nov 1, 2024

Conversation

nlouwen
Copy link
Collaborator

@nlouwen nlouwen commented Oct 30, 2024

cluster-only include and exclude categories and classes based on a simple set intersection:

  • categories are filtered before classes
  • exclude is processed before include

@nlouwen nlouwen marked this pull request as draft October 30, 2024 13:44
@nlouwen nlouwen marked this pull request as ready for review October 31, 2024 10:34
CatarinaCarolina
CatarinaCarolina approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@CatarinaCarolina CatarinaCarolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small docstring update, otherwise lgtm!

@nlouwen nlouwen merged commit a34ee3e into dev Nov 1, 2024
7 checks passed
@nlouwen nlouwen deleted the feature/include-exclude-classes branch November 1, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatarinaCarolina CatarinaCarolina CatarinaCarolina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlouwen @CatarinaCarolina