Update Polish translation #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-dev
force-pushed
the
polish-locale
branch
from
18d8b41 to
ee4e70d
Compare
rafa8626
reviewed
Jan 10, 2017
| @@ -33,10 +33,10 @@ | |||
| "mejs.fullscreen": "Pełny ekran", | |||
|
|
|||
| // mediaelementplayer-feature-jumpforward | |||
| //"mejs.time-jump-forward": "Jump forward %1 second(s)", | |||
| "mejs.time-jump-forward": "Przewiń do przodu o %1 sek.", | |||
There was a problem hiding this comment.
According to the rules of plurals, it should be 3 translations, and I only see one, can you add the other 2 please?
There was a problem hiding this comment.
Also, the mejs.time-skip-back needs the other 2 translations
rafa8626
reviewed
Jan 10, 2017
| //"mejs.ad-skip": "Skip ad", | ||
| //"mejs.ad-skip-info": "Skip in %1 second(s)", | ||
| "mejs.ad-skip": "Pomiń reklamę", | ||
| "mejs.ad-skip-info": "Pomiń za %1 sek.", |
There was a problem hiding this comment.
According to the rules of plurals, it should be 3 translations, and I only see one, can you add the other 2 please?
|
LGTM as long as you add the missing items I pointed out are addressed |
|
I've just added the missing grammar forms. |
greg-dev
force-pushed
the
polish-locale
branch
from
4194a0c to
5301ece
Compare
|
Thanks for your PR. Merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.