feat(#8986): Look up a single user from their username #8959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
kennsippell
reviewed
Apr 2, 2024
api/src/controllers/users.js
Outdated
| }; | ||
| } | ||
|
|
||
| const body = await users.getUser(username); |
There was a problem hiding this comment.
This appears to be working fine but my feedback is that since we are looking up one user, the successful response should maybe not be an array with 1 element but rather just the single result directly.
m5r
changed the title
m5r
force-pushed
the
8877-lookup-single-user-by-username
branch
2 times, most recently
from
e035a11 to
6f51da9
Compare
m5r
force-pushed
the
8877-lookup-single-user-by-username
branch
from
6f51da9 to
bc1d524
Compare
|
Superseded by #9016, closing this one |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#8877
Adds a new route
GET /api/v2/users/:usernameto get a single user. Regular users can only query themselves, users with thecan_view_userspermission can query anyone.Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.