Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing other notes on encrypt/decrypt #161

Open
ileio opened this issue May 6, 2024 · 13 comments
Open

Closing other notes on encrypt/decrypt #161

ileio opened this issue May 6, 2024 · 13 comments
Assignees
Labels
bug Something isn't working feat-whole-note Feature: Whole note encryption in testing Released in a beta version for testing
Milestone

Comments

@ileio
Copy link

ileio commented May 6, 2024

When few notes are opened, when encryption/decryption applied to one of them - only encrypted note left, other being closed

@meld-cp
Copy link
Owner

meld-cp commented May 6, 2024

Hi @ileio , which version of the plugin are you seeing this with?

@ileio
Copy link
Author

ileio commented May 6, 2024

Version 2.3.7

@meld-cp
Copy link
Owner

meld-cp commented May 6, 2024

Does it still happen with 2.4.0-beta?

@ileio
Copy link
Author

ileio commented May 7, 2024

Yes, still happening.
But now it's closing only one note. And from encrypted note I can go back to closed note by pressing arrow back :)

Forgot to mention - I'm using Obsidian with latest MacOS, maybe it's worth to know.

@meld-cp
Copy link
Owner

meld-cp commented May 8, 2024

Hi @ileio, could you run me through the steps to reproduce this issue?

Is it: you have multiple notes open, then from the file navigation, you click on one of the notes and choose encrypt/decrypt..?

@meld-cp meld-cp added the need info Further information is needed label May 8, 2024
@ileio
Copy link
Author

ileio commented May 8, 2024

Hi,
It's very simple: open two notes at once, encrypt (or decrypt if already encrypted) one of then - second note will be closed)

@meld-cp
Copy link
Owner

meld-cp commented May 8, 2024

How do you trigger the encrypt or decrypt? Command pallet?

@ileio
Copy link
Author

ileio commented May 8, 2024

Haven't tried command pallet actually.
I've tried right-press on notes name at sidebar or press on three dotes at the top right corner, then "Encrypt note". Same result for both ways

@meld-cp
Copy link
Owner

meld-cp commented May 8, 2024

Thanks, I'll see if I have time this weekend to take a look at it 👍

@meld-cp meld-cp added bug Something isn't working feat-whole-note Feature: Whole note encryption and removed need info Further information is needed labels May 8, 2024
@ileio
Copy link
Author

ileio commented May 8, 2024

Thank you :)

@meld-cp meld-cp self-assigned this May 17, 2024
@meld-cp
Copy link
Owner

meld-cp commented May 18, 2024

hey @ileio , try 2.4.0-beta.2

The target note still needs to be closed and reopened, but at least any other notes should still stay open.

@meld-cp meld-cp added the in testing Released in a beta version for testing label May 18, 2024
@ileio
Copy link
Author

ileio commented May 19, 2024

Now everything is fine - target note indeed closes and reopens and other notes are don't touched. Thanks!

@meld-cp
Copy link
Owner

meld-cp commented May 19, 2024

Awesome, thanks for testing 🙂

@meld-cp meld-cp added this to the v2.4.0 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feat-whole-note Feature: Whole note encryption in testing Released in a beta version for testing
Projects
None yet
Development

No branches or pull requests

2 participants