Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target-postgres has a default for port not obvious in meltano interac… #1080

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

visch
Copy link
Contributor

@visch visch commented Dec 9, 2022

target-postgres has a default in target.py here https://github.com/MeltanoLabs/target-postgres/blob/main/target_postgres/target.py#L62

This isn't reflected in the interactive window

image

I could add a value here as well? Maybe the automation needs this added @pnadolny13 ?

@netlify
Copy link

netlify bot commented Dec 9, 2022

👷 Deploy request for meltano-hub pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a5b5c49

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Testing plugin target-postgres (meltanolabs variant):

Starting test job...
...
Job completed.

Version info
target-postgres v0.0.1, Meltano SDK v0.14.0
Usage info
melty-bot % target-postgres --help
Usage: target-postgres [OPTIONS]

  Execute the Singer target.

Options:
  --input FILENAME          A path to read messages from instead of from
                            standard in.
  --config TEXT             Configuration file location or 'ENV' to use
                            environment variables.
  --format [json|markdown]  Specify output style for --about
  --about                   Display package metadata and settings.
  --version                 Display the package version.
  --help                    Show this message and exit.
Detected capabilities
  • ❌ 'discover'
  • ❌ 'catalog'
  • ❌ 'properties'
  • ❌ 'state'
  • ✅ 'about'
JSON Metadata
{
  "name": "target-postgres",
  "description": "Target for Postgres.",
  "version": "0.0.1",
  "sdk_version": "0.14.0",
  "capabilities": [
    "about",
    "stream-maps",
    "schema-flattening"
  ],
  "settings": {
    "type": "object",
    "properties": {
      "host": {
        "type": [
          "string",
          "null"
        ],
        "description": "Hostname for postgres instance. Note if sqlalchemy_url is set this will be ignored."
      },
      "port": {
        "type": [
          "integer",
          "null"
        ],
        "default": 5432,
        "description": "The port on which postgres is awaiting connection. Note if sqlalchemy_url is set this will be ignored."
      },
      "user": {
        "type": [
          "string",
          "null"
        ],
        "description": [
          "User name used to authenticate. Note if sqlalchemy_url is set this will be ignored."
        ]
      },
      "password": {
        "type": [
          "string",
          "null"
        ],
        "description": "Password used to authenticate. Note if sqlalchemy_url is set this will be ignored."
      },
      "database": {
        "type": [
          "string",
          "null"
        ],
        "description": "Database name. Note if sqlalchemy_url is set this will be ignored."
      },
      "sqlalchemy_url": {
        "type": [
          "string",
          "null"
        ],
        "description": "SQLAlchemy connection string. This will override using host, user, password, port,dialect. Note that you must esacpe password specialcharacters properly seehttps://docs.sqlalchemy.org/en/20/core/engines.html#escaping-special-characters-such-as-signs-in-passwords"
      },
      "dialect+driver": {
        "type": [
          "string",
          "null"
        ],
        "default": "postgresql+psycopg2",
        "description": "Dialect+driver see https://docs.sqlalchemy.org/en/20/core/engines.html. Generally just leave this alone. Note if sqlalchemy_url is set this will be ignored."
      },
      "default_target_schema": {
        "type": [
          "string",
          "null"
        ],
        "description": "Postgres schema to send data to, example: tap-clickup"
      },
      "stream_maps": {
        "type": [
          "object",
          "null"
        ],
        "properties": {},
        "description": "Config object for stream maps capability. For more information check out [Stream Maps](https://sdk.meltano.com/en/latest/stream_maps.html)."
      },
      "stream_map_config": {
        "type": [
          "object",
          "null"
        ],
        "properties": {},
        "description": "User-defined config values to be used within map expressions."
      },
      "flattening_enabled": {
        "type": [
          "boolean",
          "null"
        ],
        "description": "'True' to enable schema flattening and automatically expand nested properties."
      },
      "flattening_max_depth": {
        "type": [
          "integer",
          "null"
        ],
        "description": "The max depth to flatten schemas."
      }
    }
  }
}

@pnadolny13
Copy link
Contributor

@visch this is a good point, we've had this discussion in the past a few times. I went ahead and created #1081 to talk it through once and for all, and to have an artifact for the answer. Let me know what you think.

@tayloramurphy
Copy link
Collaborator

Approving this change but good to have the discussion.

@pnadolny13 pnadolny13 merged commit 77a2659 into meltano:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants